Skip to content

Commit

Permalink
Rename cypher suite modules consistently
Browse files Browse the repository at this point in the history
  • Loading branch information
boggle committed Jun 17, 2016
1 parent eeb04c3 commit 4aa2a57
Show file tree
Hide file tree
Showing 74 changed files with 1,884 additions and 18 deletions.
Expand Up @@ -11,11 +11,11 @@
</parent>

<modelVersion>4.0.0</modelVersion>
<artifactId>neo4j-cypher-acceptance</artifactId>
<artifactId>neo4j-cypher-acceptance-spec-suite</artifactId>
<packaging>jar</packaging>
<version>3.1.0-SNAPSHOT</version>
<name>Neo4j - Cypher Acceptance</name>
<description>Neo4j query language acceptance tests</description>
<description>Neo4j - Cypher Acceptance Specification Suite</description>
<url>http://components.neo4j.org/${project.artifactId}/${project.version}</url>

<scm>
Expand Down
Expand Up @@ -11,10 +11,10 @@
</parent>

<modelVersion>4.0.0</modelVersion>
<artifactId>neo4j-cypher-compatibility-suite</artifactId>
<artifactId>neo4j-cypher-compatibility-spec-suite</artifactId>
<packaging>jar</packaging>
<version>3.1.0-SNAPSHOT</version>
<name>Neo4j - Cypher Compatibility Suite</name>
<name>Neo4j - Cypher Compatibility Specification Suite</name>
<description>Neo4j query language compatibility suite</description>
<url>http://components.neo4j.org/${project.artifactId}/${project.version}</url>

Expand Down
Expand Up @@ -36,9 +36,9 @@
import org.junit.runners.model.RunnerBuilder;
import org.opencypher.tools.tck.TCKCucumberTemplate;

public class UnpackedResources extends Enclosed
public class CompatibilitySpecSuiteResources extends Enclosed
{
public UnpackedResources( Class<?> klass, RunnerBuilder builder ) throws Throwable
public CompatibilitySpecSuiteResources( Class<?> klass, RunnerBuilder builder ) throws Throwable
{
super( klass, download( builder ) );
}
Expand Down Expand Up @@ -105,7 +105,7 @@ public static File targetDirectory( String suffix )

private static File obtainTargetDirectory( boolean create, String suffix )
{
File directory = new File( new File( "target" ), suffix ).getAbsoluteFile();
File directory = new File( new File ( new File( "target" ), "compatibility-spec-suite" ), suffix ).getAbsoluteFile();
if ( !directory.exists() )
{
if ( !(create && directory.mkdirs()) )
Expand Down
Expand Up @@ -23,8 +23,8 @@
import cucumber.api.junit.Cucumber;
import org.junit.runner.RunWith;

@RunWith( UnpackedResources.class )
public class CompatibilitySuiteTest
@RunWith( CompatibilitySpecSuiteResources.class )
public class CompatibilitySpecSuiteTest
{

// These two constants are only used to make testing and debugging easier.
Expand Down
Expand Up @@ -24,15 +24,15 @@
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.isEmptyString;

public class CompatibilitySuiteTestConstantsTest
public class CompatibilitySpecSuiteTestConstantsTest
{
@Test
public void runsAllFeatures() {
assertThat( CompatibilitySuiteTest.FEATURE_TO_RUN, isEmptyString());
assertThat( CompatibilitySpecSuiteTest.FEATURE_TO_RUN, isEmptyString());
}

@Test
public void runsAllScenarios() {
assertThat( CompatibilitySuiteTest.SCENARIO_NAME_REQUIRED, isEmptyString());
assertThat( CompatibilitySpecSuiteTest.SCENARIO_NAME_REQUIRED, isEmptyString());
}
}
Expand Up @@ -20,13 +20,13 @@
package cypher.feature.steps

import cypher.cucumber.db.{GraphArchiveLibrary, GraphFileRepository}
import cypher.{CompatibilitySuiteTest, UnpackedResources}
import cypher.{CompatibilitySpecSuiteTest, CompatibilitySpecSuiteResources}

import scala.reflect.io.Path

class CompatibilitySuiteSteps extends SpecSuiteSteps {
class CompatibilitySpecSuiteSteps extends SpecSuiteSteps {

override val requiredScenarioName: String = CompatibilitySuiteTest.SCENARIO_NAME_REQUIRED.trim.toLowerCase
override val requiredScenarioName: String = CompatibilitySpecSuiteTest.SCENARIO_NAME_REQUIRED.trim.toLowerCase

override val unsupportedScenarios = Set("Fail when adding new label predicate on already bound node 5",
"Fail when trying to compare strings and numbers",
Expand Down Expand Up @@ -58,7 +58,7 @@ class CompatibilitySuiteSteps extends SpecSuiteSteps {
"Copying properties from literal map with ON MATCH" // wrong output format (?)
)

override val graphArchiveLibrary = new GraphArchiveLibrary(new GraphFileRepository(Path(UnpackedResources.targetDirectory("graphs"))))
override val graphArchiveLibrary = new GraphArchiveLibrary(new GraphFileRepository(Path(CompatibilitySpecSuiteResources.targetDirectory("graphs"))))
}


4 changes: 2 additions & 2 deletions community/cypher/pom.xml
Expand Up @@ -37,8 +37,8 @@
<module>cypher-compiler-3.1</module>
<module>cypher</module>
<module>spec-suite-tools</module>
<module>acceptance</module>
<module>compatibility-suite</module>
<module>acceptance-spec-suite</module>
<module>compatibility-spec-suite</module>
</modules>

<build>
Expand Down

0 comments on commit 4aa2a57

Please sign in to comment.