Skip to content

Commit

Permalink
Move GraphDatabaseAPI to internal pkgs
Browse files Browse the repository at this point in the history
  • Loading branch information
davidegrohmann committed Feb 25, 2016
1 parent d5af4cb commit 55b75d3
Show file tree
Hide file tree
Showing 194 changed files with 222 additions and 223 deletions.
Expand Up @@ -53,7 +53,7 @@
import org.neo4j.graphdb.factory.Description;
import org.neo4j.helpers.HostnamePort;
import org.neo4j.helpers.Service;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.configuration.Config;
import org.neo4j.kernel.configuration.ConfigValues;
import org.neo4j.kernel.extension.KernelExtensionFactory;
Expand Down
Expand Up @@ -21,7 +21,7 @@

import org.neo4j.bolt.v1.runtime.Session;
import org.neo4j.bolt.v1.runtime.Sessions;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.impl.core.ThreadToStatementContextBridge;
import org.neo4j.kernel.impl.logging.LogService;
import org.neo4j.kernel.impl.query.QueryExecutionEngine;
Expand Down
Expand Up @@ -34,10 +34,10 @@
import org.neo4j.bolt.v1.runtime.internal.StandardSessions;
import org.neo4j.bolt.v1.runtime.internal.concurrent.ThreadedSessions;
import org.neo4j.graphdb.DependencyResolver;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.impl.core.ThreadToStatementContextBridge;
import org.neo4j.kernel.impl.logging.NullLogService;
import org.neo4j.kernel.impl.util.Neo4jJobScheduler;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.lifecycle.LifeSupport;
import org.neo4j.test.TestGraphDatabaseFactory;
import org.neo4j.udc.UsageData;
Expand Down
Expand Up @@ -33,7 +33,7 @@
import org.neo4j.io.fs.DefaultFileSystemAbstraction;
import org.neo4j.io.fs.FileSystemAbstraction;
import org.neo4j.io.pagecache.PageCache;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.api.ReadOperations;
import org.neo4j.kernel.api.direct.DirectStoreAccess;
import org.neo4j.kernel.api.exceptions.TransactionFailureException;
Expand Down
Expand Up @@ -48,7 +48,7 @@
import org.neo4j.helpers.UTF8;
import org.neo4j.helpers.collection.Pair;
import org.neo4j.helpers.progress.ProgressMonitorFactory;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.api.ReadOperations;
import org.neo4j.kernel.api.TokenWriteOperations;
import org.neo4j.kernel.api.direct.DirectStoreAccess;
Expand Down
Expand Up @@ -38,7 +38,7 @@
import org.neo4j.io.fs.DefaultFileSystemAbstraction;
import org.neo4j.io.fs.FileSystemAbstraction;
import org.neo4j.io.pagecache.PageCache;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.api.ReadOperations;
import org.neo4j.kernel.api.direct.DirectStoreAccess;
import org.neo4j.kernel.api.exceptions.TransactionFailureException;
Expand Down
Expand Up @@ -54,7 +54,7 @@
import org.neo4j.helpers.UTF8;
import org.neo4j.helpers.collection.Pair;
import org.neo4j.helpers.progress.ProgressMonitorFactory;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.api.ReadOperations;
import org.neo4j.kernel.api.TokenWriteOperations;
import org.neo4j.kernel.api.direct.DirectStoreAccess;
Expand Down
Expand Up @@ -28,9 +28,9 @@ import org.neo4j.cypher.internal.compiler.v3_0.spi._
import org.neo4j.cypher.internal.frontend.v3_0.ast.{Add, Expression, SignedDecimalIntegerLiteral, StringLiteral}
import org.neo4j.cypher.internal.frontend.v3_0.test_helpers.CypherFunSuite
import org.neo4j.cypher.internal.frontend.v3_0.{ParameterNotFoundException, DummyPosition, InvalidArgumentException, symbols}
import org.neo4j.kernel.GraphDatabaseAPI
import org.neo4j.kernel.api.Statement
import org.neo4j.kernel.api.txstate.TxStateHolder
import org.neo4j.kernel.internal.GraphDatabaseAPI

import scala.collection.mutable

Expand Down
Expand Up @@ -21,7 +21,7 @@

import org.neo4j.cypher.javacompat.internal.GraphDatabaseCypherService;
import org.neo4j.helpers.Service;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.impl.logging.LogService;
import org.neo4j.kernel.impl.query.QueryEngineProvider;
import org.neo4j.kernel.impl.query.QueryExecutionEngine;
Expand Down
Expand Up @@ -28,7 +28,7 @@
import org.neo4j.graphdb.Relationship;
import org.neo4j.graphdb.Transaction;
import org.neo4j.graphdb.security.URLAccessValidationError;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.GraphDatabaseQueryService;

public class GraphDatabaseCypherService implements GraphDatabaseQueryService
Expand Down
Expand Up @@ -21,7 +21,7 @@ package org.neo4j.cypher.internal.spi

import org.neo4j.cypher.internal.compiler.v3_0.spi.TransactionalContext
import org.neo4j.graphdb.{Lock, PropertyContainer, Transaction}
import org.neo4j.kernel.{GraphDatabaseQueryService, GraphDatabaseAPI}
import org.neo4j.kernel.GraphDatabaseQueryService
import org.neo4j.kernel.api.{ReadOperations, Statement}
import org.neo4j.kernel.api.txstate.TxStateHolder
import org.neo4j.kernel.impl.api.KernelStatement
Expand Down
Expand Up @@ -32,8 +32,8 @@ import org.neo4j.graphdb.event.{KernelEventHandler, TransactionEventHandler}
import org.neo4j.graphdb.index.IndexManager
import org.neo4j.graphdb.schema.Schema
import org.neo4j.graphdb.traversal.{BidirectionalTraversalDescription, TraversalDescription}
import org.neo4j.kernel.GraphDatabaseAPI
import org.neo4j.kernel.impl.store.StoreId
import org.neo4j.kernel.internal.GraphDatabaseAPI
import org.neo4j.test.TestGraphDatabaseFactory

import scala.collection.JavaConverters._
Expand Down
Expand Up @@ -41,12 +41,12 @@ import org.neo4j.cypher.internal.frontend.v3_0.symbols.CTInteger
import org.neo4j.cypher.internal.spi.v3_0.MonoDirectionalTraversalMatcher
import org.neo4j.cypher.javacompat.internal.GraphDatabaseCypherService
import org.neo4j.graphdb._
import org.neo4j.kernel.GraphDatabaseAPI
import org.neo4j.kernel.api.{ReadOperations, Statement}
import org.neo4j.kernel.configuration.Config
import org.neo4j.kernel.impl.api.OperationsFacade
import org.neo4j.kernel.impl.core.{NodeManager, NodeProxy, ThreadToStatementContextBridge}
import org.neo4j.kernel.impl.transaction.log.TransactionIdStore
import org.neo4j.kernel.internal.GraphDatabaseAPI

// TODO: this test is horribly broken, it relies on mocking the core API for verification, but the internals don't use the core API
class LazyTest extends ExecutionEngineFunSuite {
Expand Down
Expand Up @@ -31,10 +31,10 @@ import org.neo4j.cypher.internal.frontend.v3_0.test_helpers.CypherFunSuite
import org.neo4j.cypher.internal.frontend.v3_0.{SemanticTable, symbols}
import org.neo4j.cypher.internal.spi.ExtendedTransactionalContext
import org.neo4j.graphdb.Node
import org.neo4j.kernel.GraphDatabaseAPI
import org.neo4j.kernel.api.txstate.TxStateHolder
import org.neo4j.kernel.api.{ReadOperations, Statement}
import org.neo4j.kernel.impl.core.{NodeManager, NodeProxy}
import org.neo4j.kernel.internal.GraphDatabaseAPI

import scala.collection.mutable

Expand Down
2 changes: 1 addition & 1 deletion community/jmx/src/main/java/org/neo4j/jmx/JmxUtils.java
Expand Up @@ -26,7 +26,7 @@

import org.neo4j.graphdb.GraphDatabaseService;
import org.neo4j.jmx.impl.JmxKernelExtension;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;

import static java.lang.String.format;

Expand Down
Expand Up @@ -30,7 +30,7 @@

import org.neo4j.graphdb.GraphDatabaseService;
import org.neo4j.jmx.impl.JmxKernelExtension;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.test.TestGraphDatabaseFactory;

import static java.lang.management.ManagementFactory.getPlatformMBeanServer;
Expand Down
Expand Up @@ -28,6 +28,7 @@
import org.neo4j.io.fs.FileSystemAbstraction;
import org.neo4j.io.pagecache.PageCache;
import org.neo4j.kernel.configuration.Config;
import org.neo4j.kernel.internal.GraphDatabaseAPI;

/**
* @deprecated This will be moved to internal packages in the next major release.
Expand Down
Expand Up @@ -27,7 +27,7 @@
import org.neo4j.io.fs.FileSystemAbstraction;
import org.neo4j.io.pagecache.PageCache;
import org.neo4j.kernel.DatabaseAvailability;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.KernelData;
import org.neo4j.kernel.NeoStoreDataSource;
import org.neo4j.kernel.Version;
Expand Down
Expand Up @@ -49,7 +49,7 @@
import org.neo4j.graphdb.traversal.TraversalDescription;
import org.neo4j.helpers.collection.PrefetchingResourceIterator;
import org.neo4j.helpers.collection.ResourceClosingIterator;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.api.KernelTransaction;
import org.neo4j.kernel.api.ReadOperations;
import org.neo4j.kernel.api.Statement;
Expand Down
Expand Up @@ -20,7 +20,7 @@
package org.neo4j.kernel.impl.query;

import org.neo4j.helpers.Service;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;

public abstract class QueryEngineProvider extends Service
{
Expand Down
Expand Up @@ -27,7 +27,7 @@
import org.neo4j.graphdb.RelationshipType;
import org.neo4j.graphdb.Transaction;
import org.neo4j.helpers.collection.Visitable;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.api.ReadOperations;
import org.neo4j.kernel.api.Statement;
import org.neo4j.kernel.api.StatementTokenNameLookup;
Expand Down
Expand Up @@ -17,7 +17,7 @@
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package org.neo4j.kernel;
package org.neo4j.kernel.internal;

import java.net.URL;

Expand All @@ -28,10 +28,7 @@

/**
* This API can be used to get access to services.
*
* @deprecated This will be moved to internal packages in the next major release.
*/
@Deprecated
public interface GraphDatabaseAPI extends GraphDatabaseService
{
/**
Expand Down
Expand Up @@ -26,7 +26,7 @@
import org.neo4j.graphdb.Relationship;
import org.neo4j.graphdb.RelationshipType;
import org.neo4j.graphdb.ResourceIterable;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.impl.api.TokenAccess;
import org.neo4j.kernel.impl.core.ThreadToStatementContextBridge;

Expand Down
Expand Up @@ -23,7 +23,7 @@
import org.junit.Test;

import org.neo4j.graphdb.factory.GraphDatabaseSettings;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.configuration.Config;
import org.neo4j.kernel.impl.MyRelTypes;
import org.neo4j.test.ImpermanentDatabaseRule;
Expand Down
Expand Up @@ -29,7 +29,7 @@
import java.util.stream.Stream;

import org.neo4j.graphdb.factory.GraphDatabaseSettings;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.impl.logging.LogService;
import org.neo4j.kernel.impl.logging.StoreLogService;
import org.neo4j.test.TargetDirectory;
Expand Down
Expand Up @@ -26,7 +26,7 @@
import org.junit.Test;

import org.neo4j.graphdb.factory.GraphDatabaseSettings;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.impl.locking.LockCountVisitor;
import org.neo4j.kernel.impl.locking.Locks;
import org.neo4j.test.TestGraphDatabaseFactory;
Expand Down
Expand Up @@ -30,7 +30,7 @@
import org.neo4j.collection.primitive.PrimitiveLongSet;
import org.neo4j.graphdb.schema.IndexDefinition;
import org.neo4j.helpers.collection.Iterables;
import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.kernel.api.ReadOperations;
import org.neo4j.kernel.api.Statement;
import org.neo4j.kernel.api.exceptions.index.IndexNotFoundKernelException;
Expand Down
Expand Up @@ -24,7 +24,7 @@

import java.util.Set;

import org.neo4j.kernel.GraphDatabaseAPI;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.test.DatabaseRule;
import org.neo4j.test.EmbeddedDatabaseRule;

Expand All @@ -51,7 +51,7 @@ public void shouldGetNodesWithCreatedLabel() throws Exception
Node node3 = createLabeledNode( Labels.Third );
Node node4 = createLabeledNode( Labels.First, Labels.Second, Labels.Third );
Node node5 = createLabeledNode( Labels.First, Labels.Third );

// THEN
assertEquals(
asSet( node1, node4, node5 ),
Expand All @@ -63,7 +63,7 @@ public void shouldGetNodesWithCreatedLabel() throws Exception
asSet( node3, node4, node5 ),
asSet( getAllNodesWithLabel( Labels.Third ) ) );
}

@Test
public void shouldGetNodesWithAddedLabel() throws Exception
{
Expand All @@ -73,11 +73,11 @@ public void shouldGetNodesWithAddedLabel() throws Exception
Node node3 = createLabeledNode( Labels.Third );
Node node4 = createLabeledNode( Labels.First );
Node node5 = createLabeledNode( Labels.First );

// WHEN
addLabels( node4, Labels.Second, Labels.Third );
addLabels( node5, Labels.Third );

// THEN
assertEquals(
asSet( node1, node4, node5 ),
Expand All @@ -89,17 +89,17 @@ public void shouldGetNodesWithAddedLabel() throws Exception
asSet( node3, node4, node5 ),
asSet( getAllNodesWithLabel( Labels.Third ) ) );
}

@Test
public void shouldGetNodesAfterDeletedNodes() throws Exception
{
// GIVEN
Node node1 = createLabeledNode( Labels.First, Labels.Second );
Node node2 = createLabeledNode( Labels.First, Labels.Third );

// WHEN
deleteNode( node1 );

// THEN
assertEquals(
asSet( node2 ),
Expand All @@ -111,18 +111,18 @@ public void shouldGetNodesAfterDeletedNodes() throws Exception
asSet( node2 ),
getAllNodesWithLabel( Labels.Third ) );
}

@Test
public void shouldGetNodesAfterRemovedLabels() throws Exception
{
// GIVEN
Node node1 = createLabeledNode( Labels.First, Labels.Second );
Node node2 = createLabeledNode( Labels.First, Labels.Third );

// WHEN
removeLabels( node1, Labels.First );
removeLabels( node2, Labels.Third );

// THEN
assertEquals(
asSet( node2 ),
Expand Down Expand Up @@ -176,7 +176,7 @@ public void shouldHandleLargeAmountsOfNodesAddedAndRemovedInSameTx() throws Exce
}
}
}

private void removeLabels( Node node, Label... labels )
{
try ( Transaction tx = dbRule.getGraphDatabaseService().beginTx() )
Expand Down Expand Up @@ -215,7 +215,7 @@ private Node createLabeledNode( Label... labels )
return node;
}
}

private void addLabels( Node node, Label... labels )
{
try ( Transaction tx = dbRule.getGraphDatabaseService().beginTx() )
Expand Down
Expand Up @@ -33,6 +33,7 @@

import org.neo4j.io.fs.DefaultFileSystemAbstraction;
import org.neo4j.kernel.configuration.Config;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.test.PageCacheRule;

import static org.junit.Assert.assertEquals;
Expand Down
Expand Up @@ -45,6 +45,7 @@
import org.neo4j.kernel.impl.storemigration.LogFiles;
import org.neo4j.kernel.impl.transaction.command.Command;
import org.neo4j.kernel.internal.DatabaseHealth;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.test.AdversarialPageCacheGraphDatabaseFactory;
import org.neo4j.test.TargetDirectory;
import org.neo4j.test.TestGraphDatabaseFactory;
Expand Down
Expand Up @@ -29,6 +29,7 @@
import org.neo4j.kernel.guard.GuardOperationsCountException;
import org.neo4j.kernel.guard.GuardTimeoutException;
import org.neo4j.kernel.impl.util.UnsatisfiedDependencyException;
import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.test.TestGraphDatabaseFactory;

import static java.lang.Integer.MAX_VALUE;
Expand Down

0 comments on commit 55b75d3

Please sign in to comment.