Rename tests that use shared system resources to IT tests to match

failsafe plugin expectations.
Disable forked execution in modules that have tests relying on specific
port.

community/neo4j-harness/pom.xml

@@ -54,6 +54,17 @@
     </license>
   </licenses>
 
+  <build>
+    <plugins>
+      <plugin>
+        <artifactId>maven-failsafe-plugin</artifactId>
+        <configuration>
+          <forkCount>1</forkCount>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
+
   <dependencies>
 
     <dependency>

community/neo4j-harness/src/test/java/org/neo4j/harness/FixturesTest.java → community/neo4j-harness/src/test/java/org/neo4j/harness/FixturesTestIT.java

@@ -41,7 +41,7 @@
 import static org.neo4j.harness.TestServerBuilders.newInProcessBuilder;
 import static org.neo4j.test.server.HTTP.RawPayload.quotedJson;
 
-public class FixturesTest
+public class FixturesTestIT
 {
     @Rule
     public TestDirectory testDir = TestDirectory.testDirectory();

community/neo4j-harness/src/test/java/org/neo4j/harness/InProcessBuilderTest.java → community/neo4j-harness/src/test/java/org/neo4j/harness/InProcessBuilderTestIT.java

@@ -71,7 +71,7 @@
 import static org.neo4j.harness.TestServerBuilders.newInProcessBuilder;
 import static org.neo4j.helpers.collection.MapUtil.stringMap;
 
-public class InProcessBuilderTest
+public class InProcessBuilderTestIT
 {
     @Rule
     public TestDirectory testDir = TestDirectory.testDirectory();

community/neo4j-harness/src/test/java/org/neo4j/harness/JUnitRuleTest.java → community/neo4j-harness/src/test/java/org/neo4j/harness/JUnitRuleTestIT.java

@@ -45,7 +45,7 @@
 import static org.neo4j.server.ServerTestUtils.getSharedTestTemporaryFolder;
 import static org.neo4j.test.server.HTTP.RawPayload.quotedJson;
 
-public class JUnitRuleTest
+public class JUnitRuleTestIT
 {
     @Rule
     public TestDirectory testDirectory = TestDirectory.testDirectory();

community/neo4j-harness/src/test/java/org/neo4j/harness/JavaAggregationFunctionsTest.java → community/neo4j-harness/src/test/java/org/neo4j/harness/JavaAggregationFunctionsTestIT.java

@@ -33,7 +33,7 @@
 import static org.junit.Assert.assertEquals;
 import static org.neo4j.test.server.HTTP.RawPayload.quotedJson;
 
-public class JavaAggregationFunctionsTest
+public class JavaAggregationFunctionsTestIT
 {
     @Rule
     public TestDirectory testDir = TestDirectory.testDirectory();

community/neo4j-harness/src/test/java/org/neo4j/harness/JavaFunctionsTest.java → community/neo4j-harness/src/test/java/org/neo4j/harness/JavaFunctionsTestIT.java

@@ -35,7 +35,7 @@
 import static org.junit.Assert.assertThat;
 import static org.neo4j.test.server.HTTP.RawPayload.quotedJson;
 
-public class JavaFunctionsTest
+public class JavaFunctionsTestIT
 {
     @Rule
     public TestDirectory testDir = TestDirectory.testDirectory();

community/server-plugin-test/pom.xml

@@ -50,6 +50,17 @@ the relevant Commercial Agreement.
     </license>
   </licenses>
 
+  <build>
+    <plugins>
+      <plugin>
+        <artifactId>maven-failsafe-plugin</artifactId>
+        <configuration>
+          <forkCount>1</forkCount>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
+
   <dependencies>
     <dependency>
       <groupId>org.neo4j.app</groupId>

community/server-plugin-test/src/test/java/org/neo4j/server/plugins/CloneSubgraphPluginTest.java → community/server-plugin-test/src/test/java/org/neo4j/server/plugins/CloneSubgraphPluginTestIT.java

@@ -50,7 +50,7 @@
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 
-public class CloneSubgraphPluginTest extends ExclusiveServerTestBase
+public class CloneSubgraphPluginTestIT extends ExclusiveServerTestBase
 {
     private static final RelationshipType KNOWS = RelationshipType.withName( "knows" );
     private static final RelationshipType WORKED_FOR = RelationshipType.withName( "worked_for" );

community/server-plugin-test/src/test/java/org/neo4j/server/plugins/ExtensionListingFunctionalTest.java → community/server-plugin-test/src/test/java/org/neo4j/server/plugins/ExtensionListingFunctionalTestIT.java

@@ -40,7 +40,7 @@
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertThat;
 
-public class ExtensionListingFunctionalTest extends SharedServerTestBase
+public class ExtensionListingFunctionalTestIT extends SharedServerTestBase
 {
     private static FunctionalTestHelper functionalTestHelper;
 

community/server-plugin-test/src/test/java/org/neo4j/server/plugins/PluginFunctionalTest.java → community/server-plugin-test/src/test/java/org/neo4j/server/plugins/PluginFunctionalTestIT.java

@@ -51,7 +51,7 @@
 import static org.junit.Assert.assertThat;
 
 @SuppressWarnings( "unchecked" )
-public class PluginFunctionalTest extends SharedServerTestBase
+public class PluginFunctionalTestIT extends SharedServerTestBase
 {
     private static FunctionalTestHelper functionalTestHelper;
 

community/server/src/test/java/org/neo4j/server/BaseBootstrapperTest.java → community/server/src/test/java/org/neo4j/server/BaseBootstrapperTestIT.java

@@ -30,11 +30,8 @@
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
 
-import org.neo4j.bolt.BoltKernelExtension;
 import org.neo4j.graphdb.config.Setting;
-import org.neo4j.kernel.configuration.ssl.SslPolicyConfig;
 import org.neo4j.server.configuration.ConfigLoader;
-import org.neo4j.server.configuration.ServerSettings;
 import org.neo4j.test.server.ExclusiveServerTestBase;
 
 import static org.hamcrest.Matchers.equalTo;
@@ -48,7 +45,7 @@
 import static org.neo4j.helpers.collection.MapUtil.stringMap;
 import static org.neo4j.test.assertion.Assert.assertEventually;
 
-public abstract class BaseBootstrapperTest extends ExclusiveServerTestBase
+public abstract class BaseBootstrapperTestIT extends ExclusiveServerTestBase
 {
     @Rule
     public TemporaryFolder tempDir = new TemporaryFolder();

community/server/src/test/java/org/neo4j/server/CommunityBootstrapperTest.java → community/server/src/test/java/org/neo4j/server/CommunityBootstrapperTestIT.java

@@ -19,7 +19,7 @@
  */
 package org.neo4j.server;
 
-public class CommunityBootstrapperTest extends BaseBootstrapperTest
+public class CommunityBootstrapperTestIT extends BaseBootstrapperTestIT
 {
     @Override
     protected ServerBootstrapper newBootstrapper()

community/server/src/test/java/org/neo4j/server/NeoServerRestartTestCommunity.java → community/server/src/test/java/org/neo4j/server/NeoServerRestartTestCommunityIT.java

@@ -24,7 +24,7 @@
 import org.neo4j.graphdb.factory.GraphDatabaseSettings;
 import org.neo4j.server.helpers.CommunityServerBuilder;
 
-public class NeoServerRestartTestCommunity extends NeoServerRestartTest
+public class NeoServerRestartTestCommunityIT extends NeoServerRestartTestIT
 {
     protected NeoServer getNeoServer( String customPageSwapperName ) throws IOException
     {

community/server/src/test/java/org/neo4j/server/NeoServerRestartTest.java → community/server/src/test/java/org/neo4j/server/NeoServerRestartTestIT.java

@@ -34,7 +34,7 @@
 
 import static org.junit.Assert.fail;
 
-public abstract class NeoServerRestartTest extends ExclusiveServerTestBase
+public abstract class NeoServerRestartTestIT extends ExclusiveServerTestBase
 {
     public static final String CUSTOM_SWAPPER = "CustomSwapper";
     private static Semaphore semaphore;

community/server/src/test/java/org/neo4j/server/RedirectToBrowserTest.java → community/server/src/test/java/org/neo4j/server/RedirectToBrowserTestIT.java

@@ -19,23 +19,23 @@
  */
 package org.neo4j.server;
 
-import java.io.IOException;
-import java.net.URI;
-import javax.ws.rs.core.MediaType;
-
 import com.sun.jersey.api.client.Client;
 import org.junit.AfterClass;
 import org.junit.BeforeClass;
 import org.junit.Test;
 
+import java.io.IOException;
+import java.net.URI;
+import javax.ws.rs.core.MediaType;
+
 import org.neo4j.server.helpers.ServerHelper;
 import org.neo4j.server.rest.JaxRsResponse;
 import org.neo4j.server.rest.RestRequest;
 import org.neo4j.test.server.ExclusiveServerTestBase;
 
 import static org.junit.Assert.assertEquals;
 
-public class RedirectToBrowserTest extends ExclusiveServerTestBase
+public class RedirectToBrowserTestIT extends ExclusiveServerTestBase
 {
     private static NeoServer server;
 

community/server/src/test/java/org/neo4j/server/rest/CreateRelationshipTest.java → community/server/src/test/java/org/neo4j/server/rest/CreateRelationshipTestIT.java

@@ -19,12 +19,12 @@
  */
 package org.neo4j.server.rest;
 
-import java.util.Map;
-import javax.ws.rs.core.MediaType;
-
 import com.sun.jersey.api.client.ClientResponse.Status;
 import org.junit.Test;
 
+import java.util.Map;
+import javax.ws.rs.core.MediaType;
+
 import org.neo4j.graphdb.Node;
 import org.neo4j.graphdb.RelationshipType;
 import org.neo4j.graphdb.Transaction;
@@ -36,7 +36,7 @@
 
 import static org.junit.Assert.assertTrue;
 
-public class CreateRelationshipTest extends AbstractRestFunctionalDocTestBase
+public class CreateRelationshipTestIT extends AbstractRestFunctionalDocTestBase
 {
     @Test
     @Graph( "Joe knows Sara" )

community/server/src/test/java/org/neo4j/server/rest/transactional/TransactionTest.java → community/server/src/test/java/org/neo4j/server/rest/transactional/TransactionTestIT.java

@@ -49,7 +49,7 @@
 import static org.neo4j.test.server.HTTP.GET;
 import static org.neo4j.test.server.HTTP.POST;
 
-public class TransactionTest extends AbstractRestFunctionalTestBase
+public class TransactionTestIT extends AbstractRestFunctionalTestBase
 {
     @Test
     @Documented( "Begin a transaction\n" +

community/server/src/test/java/org/neo4j/server/rest/transactional/integration/RowFormatMetaFieldTest.java → community/server/src/test/java/org/neo4j/server/rest/transactional/integration/RowFormatMetaFieldTestIT.java

@@ -38,7 +38,7 @@
 import static org.neo4j.server.rest.transactional.integration.TransactionMatchers.rowContainsMetaRelsAtIndex;
 import static org.neo4j.test.server.HTTP.RawPayload.quotedJson;
 
-public class RowFormatMetaFieldTest extends AbstractRestFunctionalTestBase
+public class RowFormatMetaFieldTestIT extends AbstractRestFunctionalTestBase
 {
     private final HTTP.Builder http = HTTP.withBaseUri( "http://localhost:7474" );
 

community/server/src/test/java/org/neo4j/server/web/TestJetty9WebServer.java → community/server/src/test/java/org/neo4j/server/web/TestJetty9WebServerIT.java

@@ -32,7 +32,7 @@
 
 import static org.neo4j.test.rule.SuppressOutput.suppressAll;
 
-public class TestJetty9WebServer extends ExclusiveServerTestBase
+public class TestJetty9WebServerIT extends ExclusiveServerTestBase
 {
     @Rule
     public SuppressOutput suppressOutput = suppressAll();

community/server/src/test/java/org/neo4j/server/web/WebServerDirectoryListingTest.java → community/server/src/test/java/org/neo4j/server/web/WebServerDirectoryListingTestIT.java

@@ -29,7 +29,7 @@
 
 import static org.junit.Assert.assertEquals;
 
-public class WebServerDirectoryListingTest extends ExclusiveServerTestBase
+public class WebServerDirectoryListingTestIT extends ExclusiveServerTestBase
 {
     private CommunityNeoServer server;
 

community/server/src/test/resources/META-INF/services/org.neo4j.io.pagecache.PageSwapperFactory

@@ -1 +1 @@
-org.neo4j.server.NeoServerRestartTest$CustomSwapper
+org.neo4j.server.NeoServerRestartTestIT$CustomSwapper

community/shell/pom.xml

@@ -59,6 +59,12 @@ the relevant Commercial Agreement.
 
   <build>
     <plugins>
+      <plugin>
+        <artifactId>maven-failsafe-plugin</artifactId>
+        <configuration>
+          <forkCount>1</forkCount>
+        </configuration>
+      </plugin>
       <plugin>
         <artifactId>maven-jar-plugin</artifactId>
         <configuration>

enterprise/backup/pom.xml

@@ -49,6 +49,12 @@
 
   <build>
     <plugins>
+      <plugin>
+        <artifactId>maven-failsafe-plugin</artifactId>
+        <configuration>
+          <forkCount>1</forkCount>
+        </configuration>
+      </plugin>
       <plugin>
         <groupId>org.neo4j.build.plugins</groupId>
         <artifactId>clirr-maven-plugin</artifactId>

enterprise/backup/src/test/java/org/neo4j/backup/TestBackup.java → enterprise/backup/src/test/java/org/neo4j/backup/BackupIT.java

@@ -86,7 +86,7 @@
 import static org.neo4j.kernel.impl.MyRelTypes.TEST;
 
 @RunWith( Parameterized.class )
-public class TestBackup
+public class BackupIT
 {
     private final TestDirectory testDir = TestDirectory.testDirectory();
     private final DefaultFileSystemRule fileSystemRule = new DefaultFileSystemRule();

enterprise/backup/src/test/java/org/neo4j/backup/IncrementalBackupTest.java → enterprise/backup/src/test/java/org/neo4j/backup/IncrementalBackupIT.java

@@ -43,7 +43,7 @@
 
 import static org.junit.Assert.assertEquals;
 
-public class IncrementalBackupTest
+public class IncrementalBackupIT
 {
     @Rule
     public TestName testName = new TestName();

enterprise/backup/src/test/java/org/neo4j/backup/TestConfiguration.java

@@ -41,6 +41,7 @@ public class TestConfiguration
     private static final File SOURCE_DIR = new File( "target/db" );
     private static final String BACKUP_DIR = "target/full-backup";
     private static final String HOST_ADDRESS = "127.0.0.1";
+    private static final int PORT = 6365;
 
     @Before
     public void before() throws Exception
@@ -52,8 +53,9 @@ public void before() throws Exception
     @Test
     public void testOnByDefault() throws Exception
     {
-        GraphDatabaseService db = new TestGraphDatabaseFactory().newEmbeddedDatabase( SOURCE_DIR );
-        OnlineBackup.from( HOST_ADDRESS ).full( BACKUP_DIR );
+        GraphDatabaseService db = new TestGraphDatabaseFactory().newEmbeddedDatabaseBuilder( SOURCE_DIR )
+                .setConfig( OnlineBackupSettings.online_backup_server, "localhost:" + PORT ).newGraphDatabase();
+        OnlineBackup.from( HOST_ADDRESS, PORT ).full( BACKUP_DIR );
         db.shutdown();
     }
 
@@ -62,10 +64,11 @@ public void testOffByConfig() throws Exception
     {
         GraphDatabaseService db = new TestGraphDatabaseFactory().newEmbeddedDatabaseBuilder( SOURCE_DIR )
                 .setConfig( OnlineBackupSettings.online_backup_enabled, Settings.FALSE )
+                .setConfig( OnlineBackupSettings.online_backup_server, "localhost:" + PORT )
                 .newGraphDatabase();
         try
         {
-            OnlineBackup.from( HOST_ADDRESS ).full( BACKUP_DIR );
+            OnlineBackup.from( HOST_ADDRESS, PORT ).full( BACKUP_DIR );
             fail( "Shouldn't be possible" );
         }
         catch ( Exception e )
@@ -79,9 +82,10 @@ public void testEnableDefaultsInConfig() throws Exception
     {
         GraphDatabaseService db = new TestGraphDatabaseFactory().newEmbeddedDatabaseBuilder( SOURCE_DIR )
                 .setConfig( OnlineBackupSettings.online_backup_enabled, Settings.TRUE )
+                .setConfig( OnlineBackupSettings.online_backup_server, "localhost:" + PORT )
                 .newGraphDatabase();
 
-        OnlineBackup.from( HOST_ADDRESS ).full( BACKUP_DIR );
+        OnlineBackup.from( HOST_ADDRESS, PORT ).full( BACKUP_DIR );
         db.shutdown();
     }
 
@@ -95,7 +99,7 @@ public void testEnableCustomPortInConfig() throws Exception
                 .newGraphDatabase();
         try
         {
-            OnlineBackup.from( HOST_ADDRESS ).full( BACKUP_DIR );
+            OnlineBackup.from( HOST_ADDRESS, 12346 ).full( BACKUP_DIR );
             fail( "Shouldn't be possible" );
         }
         catch ( Exception e )

enterprise/causal-clustering/src/test/java/org/neo4j/causalclustering/catchup/storecopy/StoreFilesWithRealFileSystemTest.java

@@ -31,7 +31,7 @@ public class StoreFilesWithRealFileSystemTest extends StoreFilesTest
     @Override
     protected void createRules()
     {
-        testDirectory = TestDirectory.testDirectory( StoreFilesTest.class );
+        testDirectory = TestDirectory.testDirectory( StoreFilesWithRealFileSystemTest.class );
         DefaultFileSystemRule defaultFileSystemRule = new DefaultFileSystemRule();
         fileSystemRule = defaultFileSystemRule::get;
         hiddenFileSystemRule = new EphemeralFileSystemRule();

enterprise/ha/src/test/java/org/neo4j/ha/TestPullUpdates.java → enterprise/ha/src/test/java/org/neo4j/ha/TestPullUpdatesIT.java

@@ -66,7 +66,7 @@
 import static org.neo4j.kernel.impl.ha.ClusterManager.masterAvailable;
 import static org.neo4j.kernel.impl.ha.ClusterManager.masterSeesSlavesAsAvailable;
 
-public class TestPullUpdates
+public class TestPullUpdatesIT
 {
     private static final int PULL_INTERVAL = 100;
     private static final int SHELL_PORT = 6370;

enterprise/ha/src/test/java/org/neo4j/kernel/ha/TestBasicHaOperations.java → enterprise/ha/src/test/java/org/neo4j/kernel/ha/TestBasicHaOperationsIT.java

@@ -37,7 +37,7 @@
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
-public class TestBasicHaOperations
+public class TestBasicHaOperationsIT
 {
     @ClassRule
     public static LoggerRule logger = new LoggerRule( Level.OFF );

enterprise/kernel/pom.xml

@@ -47,6 +47,12 @@
 
   <build>
     <plugins>
+      <plugin>
+        <artifactId>maven-failsafe-plugin</artifactId>
+        <configuration>
+          <forkCount>1</forkCount>
+        </configuration>
+      </plugin>
       <plugin>
         <groupId>net.alchim31.maven</groupId>
         <artifactId>scala-maven-plugin</artifactId>