Better packaging for metrics

neo4j · Dec 9, 2015 · 595e8a2 · 595e8a2
1 parent d7ade7c
commit 595e8a2
Show file tree

Hide file tree

Showing 18 changed files with 58 additions and 47 deletions.
diff --git a/enterprise/metrics/pom.xml b/enterprise/metrics/pom.xml
@@ -55,17 +55,17 @@
                       classpathref="maven.test.classpath" failonerror="true">
                   <arg value="--output=${project.build.directory}/docs/ops/available-metrics.asciidoc" />
 
-                  <arg value="org.neo4j.metrics.source.CheckPointingMetrics" />
-                  <arg value="org.neo4j.metrics.source.EntityCountMetrics" />
-                  <arg value="org.neo4j.metrics.source.PageCacheMetrics" />
-                  <arg value="org.neo4j.metrics.source.TransactionMetrics" />
-                  <arg value="org.neo4j.metrics.source.CypherMetrics" />
-                  <arg value="org.neo4j.metrics.source.LogRotationMetrics" />
+                  <arg value="org.neo4j.metrics.source.db.CheckPointingMetrics" />
+                  <arg value="org.neo4j.metrics.source.db.EntityCountMetrics" />
+                  <arg value="org.neo4j.metrics.source.db.PageCacheMetrics" />
+                  <arg value="org.neo4j.metrics.source.db.TransactionMetrics" />
+                  <arg value="org.neo4j.metrics.source.db.CypherMetrics" />
+                  <arg value="org.neo4j.metrics.source.db.LogRotationMetrics" />
 
-                  <arg value="org.neo4j.metrics.source.NetworkMetrics" />
-                  <arg value="org.neo4j.metrics.source.ClusterMetrics" />
+                  <arg value="org.neo4j.metrics.source.cluster.NetworkMetrics" />
+                  <arg value="org.neo4j.metrics.source.cluster.ClusterMetrics" />
 
-                  <arg value="org.neo4j.metrics.source.JvmMetrics" />
+                  <arg value="org.neo4j.metrics.source.jvm.JvmMetrics" />
                 </java>
               </target>
             </configuration>

diff --git a/enterprise/metrics/src/main/java/org/neo4j/metrics/MetricsExtension.java b/enterprise/metrics/src/main/java/org/neo4j/metrics/MetricsExtension.java
@@ -80,28 +80,25 @@ public void init()
         // Setup output
         boolean outputBuilt = new OutputBuilder( configuration, registry, logger, kernelContext, life ).build();
 
-        if ( outputBuilt )
+        // Setup metric gathering
+        boolean metricsBuilt = new Neo4jMetricsBuilder( registry, configuration, monitors,
+                dataSourceManager, transactionCounters, pageCacheCounters, checkPointerMonitor, logRotationMonitor,
+                idGeneratorFactory, dependencyResolver, logService, life ).build();
+
+        if ( metricsBuilt && !outputBuilt )
         {
-            // Setup metric gathering
-            boolean metricsBuilt = new Neo4jMetricsBuilder( registry, configuration, monitors,
-                    dataSourceManager, transactionCounters, pageCacheCounters, checkPointerMonitor, logRotationMonitor,
-                    idGeneratorFactory, dependencyResolver, logService, life ).build();
+            logger.warn( "Several metrics were enabled but no exporting option was configured to report values to. "
+                         +
+                         "Disabling kernel metrics extension." );
+            life.clear();
         }
-        else
-        {
-            if ( metrics.available() )
-            {
-                logger.warn( "Several metrics were enabled but no exporting option was configured to report values to. "
-                             +
-                             "Disabling kernel metrics extension." );
-            }
 
-            if ( output.available() )
-            {
-                logger.warn( "Exporting tool have been configured to report values to but no metrics were enabled. "
-                             +
-                             "Disabling kernel metrics extension." );
-            }
+        if ( outputBuilt && !metricsBuilt )
+        {
+            logger.warn( "Exporting tool have been configured to report values to but no metrics were enabled. "
+                         +
+                         "Disabling kernel metrics extension." );
+            life.clear();
         }
 
         life.init();

diff --git a/enterprise/metrics/src/main/java/org/neo4j/metrics/source/Neo4jMetricsBuilder.java b/enterprise/metrics/src/main/java/org/neo4j/metrics/source/Neo4jMetricsBuilder.java
@@ -34,6 +34,18 @@
 import org.neo4j.kernel.lifecycle.LifeSupport;
 import org.neo4j.kernel.monitoring.Monitors;
 import org.neo4j.metrics.MetricsSettings;
+import org.neo4j.metrics.source.cluster.ClusterMetrics;
+import org.neo4j.metrics.source.cluster.NetworkMetrics;
+import org.neo4j.metrics.source.db.CheckPointingMetrics;
+import org.neo4j.metrics.source.db.CypherMetrics;
+import org.neo4j.metrics.source.db.EntityCountMetrics;
+import org.neo4j.metrics.source.db.LogRotationMetrics;
+import org.neo4j.metrics.source.db.PageCacheMetrics;
+import org.neo4j.metrics.source.db.TransactionMetrics;
+import org.neo4j.metrics.source.jvm.GCMetrics;
+import org.neo4j.metrics.source.jvm.MemoryBuffersMetrics;
+import org.neo4j.metrics.source.jvm.MemoryPoolMetrics;
+import org.neo4j.metrics.source.jvm.ThreadMetrics;
 
 public class Neo4jMetricsBuilder
 {

diff --git a/.../neo4j/metrics/source/ClusterMetrics.java → ...etrics/source/cluster/ClusterMetrics.java b/.../neo4j/metrics/source/ClusterMetrics.java → ...etrics/source/cluster/ClusterMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.cluster;
 
 import com.codahale.metrics.Gauge;
 import com.codahale.metrics.MetricRegistry;

diff --git a/.../neo4j/metrics/source/NetworkMetrics.java → ...etrics/source/cluster/NetworkMetrics.java b/.../neo4j/metrics/source/NetworkMetrics.java → ...etrics/source/cluster/NetworkMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.cluster;
 
 import com.codahale.metrics.Gauge;
 import com.codahale.metrics.MetricRegistry;
@@ -31,6 +31,7 @@
 
 import org.neo4j.kernel.lifecycle.LifecycleAdapter;
 import org.neo4j.kernel.monitoring.Monitors;
+import org.neo4j.metrics.source.ByteCountsMetric;
 
 import static com.codahale.metrics.MetricRegistry.name;
 

diff --git a/.../metrics/source/CheckPointingMetrics.java → ...trics/source/db/CheckPointingMetrics.java b/.../metrics/source/CheckPointingMetrics.java → ...trics/source/db/CheckPointingMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.db;
 
 import com.codahale.metrics.Gauge;
 import com.codahale.metrics.MetricRegistry;

diff --git a/...g/neo4j/metrics/source/CypherMetrics.java → ...eo4j/metrics/source/db/CypherMetrics.java b/...g/neo4j/metrics/source/CypherMetrics.java → ...eo4j/metrics/source/db/CypherMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.db;
 
 import com.codahale.metrics.Gauge;
 import com.codahale.metrics.MetricRegistry;

diff --git a/...4j/metrics/source/EntityCountMetrics.java → ...metrics/source/db/EntityCountMetrics.java b/...4j/metrics/source/EntityCountMetrics.java → ...metrics/source/db/EntityCountMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.db;
 
 import com.codahale.metrics.Gauge;
 import com.codahale.metrics.MetricRegistry;

diff --git a/...4j/metrics/source/LogRotationMetrics.java → ...metrics/source/db/LogRotationMetrics.java b/...4j/metrics/source/LogRotationMetrics.java → ...metrics/source/db/LogRotationMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.db;
 
 import com.codahale.metrics.Gauge;
 import com.codahale.metrics.MetricRegistry;

diff --git a/...eo4j/metrics/source/PageCacheMetrics.java → ...j/metrics/source/db/PageCacheMetrics.java b/...eo4j/metrics/source/PageCacheMetrics.java → ...j/metrics/source/db/PageCacheMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.db;
 
 import com.codahale.metrics.Gauge;
 import com.codahale.metrics.MetricRegistry;

diff --git a/...4j/metrics/source/TransactionMetrics.java → ...metrics/source/db/TransactionMetrics.java b/...4j/metrics/source/TransactionMetrics.java → ...metrics/source/db/TransactionMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.db;
 
 import com.codahale.metrics.Gauge;
 import com.codahale.metrics.MetricRegistry;

diff --git a/...a/org/neo4j/metrics/source/GCMetrics.java → ...g/neo4j/metrics/source/jvm/GCMetrics.java b/...a/org/neo4j/metrics/source/GCMetrics.java → ...g/neo4j/metrics/source/jvm/GCMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.jvm;
 
 import com.codahale.metrics.Gauge;
 import com.codahale.metrics.Metric;
@@ -31,8 +31,8 @@
 import org.neo4j.kernel.lifecycle.LifecycleAdapter;
 
 import static com.codahale.metrics.MetricRegistry.name;
-import static org.neo4j.metrics.source.JvmMetrics.NAME_PREFIX;
-import static org.neo4j.metrics.source.JvmMetrics.prettifyName;
+import static org.neo4j.metrics.source.jvm.JvmMetrics.NAME_PREFIX;
+import static org.neo4j.metrics.source.jvm.JvmMetrics.prettifyName;
 
 public class GCMetrics extends LifecycleAdapter implements Lifecycle
 {

diff --git a/.../org/neo4j/metrics/source/JvmMetrics.java → .../neo4j/metrics/source/jvm/JvmMetrics.java b/.../org/neo4j/metrics/source/JvmMetrics.java → .../neo4j/metrics/source/jvm/JvmMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.jvm;
 
 import org.neo4j.kernel.impl.annotations.Documented;
 

diff --git a/.../metrics/source/MemoryBuffersMetrics.java → ...rics/source/jvm/MemoryBuffersMetrics.java b/.../metrics/source/MemoryBuffersMetrics.java → ...rics/source/jvm/MemoryBuffersMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.jvm;
 
 import com.codahale.metrics.Gauge;
 import com.codahale.metrics.Metric;
@@ -31,7 +31,7 @@
 import org.neo4j.kernel.lifecycle.LifecycleAdapter;
 
 import static com.codahale.metrics.MetricRegistry.name;
-import static org.neo4j.metrics.source.JvmMetrics.prettifyName;
+import static org.neo4j.metrics.source.jvm.JvmMetrics.prettifyName;
 
 public class MemoryBuffersMetrics extends LifecycleAdapter implements Lifecycle
 {

diff --git a/...o4j/metrics/source/MemoryPoolMetrics.java → ...metrics/source/jvm/MemoryPoolMetrics.java b/...o4j/metrics/source/MemoryPoolMetrics.java → ...metrics/source/jvm/MemoryPoolMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.jvm;
 
 import com.codahale.metrics.Gauge;
 import com.codahale.metrics.Metric;
@@ -31,7 +31,7 @@
 import org.neo4j.kernel.lifecycle.LifecycleAdapter;
 
 import static com.codahale.metrics.MetricRegistry.name;
-import static org.neo4j.metrics.source.JvmMetrics.prettifyName;
+import static org.neo4j.metrics.source.jvm.JvmMetrics.prettifyName;
 
 public class MemoryPoolMetrics extends LifecycleAdapter implements Lifecycle
 {

diff --git a/...g/neo4j/metrics/source/ThreadMetrics.java → ...o4j/metrics/source/jvm/ThreadMetrics.java b/...g/neo4j/metrics/source/ThreadMetrics.java → ...o4j/metrics/source/jvm/ThreadMetrics.java
@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.metrics.source;
+package org.neo4j.metrics.source.jvm;
 
 import com.codahale.metrics.Gauge;
 import com.codahale.metrics.MetricRegistry;

diff --git a/enterprise/metrics/src/test/java/org/neo4j/metrics/MetricsKernelExtensionFactoryIT.java b/enterprise/metrics/src/test/java/org/neo4j/metrics/MetricsKernelExtensionFactoryIT.java
@@ -37,8 +37,8 @@
 import org.neo4j.helpers.Settings;
 import org.neo4j.kernel.ha.HighlyAvailableGraphDatabase;
 import org.neo4j.kernel.impl.ha.ClusterManager;
-import org.neo4j.metrics.source.CypherMetrics;
-import org.neo4j.metrics.source.TransactionMetrics;
+import org.neo4j.metrics.source.db.CypherMetrics;
+import org.neo4j.metrics.source.db.TransactionMetrics;
 import org.neo4j.test.TargetDirectory;
 import org.neo4j.test.ha.ClusterRule;
 

diff --git a/enterprise/metrics/src/test/java/org/neo4j/metrics/source/ClusterMetricsTest.java b/enterprise/metrics/src/test/java/org/neo4j/metrics/source/ClusterMetricsTest.java
@@ -43,6 +43,7 @@
 import org.neo4j.kernel.ha.cluster.modeswitch.HighAvailabilityModeSwitcher;
 import org.neo4j.kernel.lifecycle.LifeSupport;
 import org.neo4j.kernel.monitoring.Monitors;
+import org.neo4j.metrics.source.cluster.ClusterMetrics;
 
 import static org.junit.Assert.assertEquals;
 import static org.mockito.Mockito.mock;