Fix some review comments

neo4j · Oct 3, 2018 · 5b1667c · 5b1667c
1 parent 321a81c
commit 5b1667c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/community/kernel/src/main/java/org/neo4j/kernel/api/security/AuthToken.java b/community/kernel/src/main/java/org/neo4j/kernel/api/security/AuthToken.java
@@ -72,6 +72,7 @@ else if ( !(value instanceof byte[]) )
         return (byte[]) value;
     }
 
+    @SuppressWarnings( "unchecked" )
     static Map<String,Object> safeCastMap( String key, Map<String,Object> authToken )
             throws InvalidAuthTokenException
     {
@@ -95,13 +96,13 @@ else if ( value instanceof Map )
     static void clearCredentials( Map<String,Object> authToken )
     {
         Object credentials = authToken.get( CREDENTIALS );
-        if ( credentials != null && credentials instanceof byte[] )
+        if ( credentials instanceof byte[] )
         {
             Arrays.fill( (byte[]) credentials, (byte) 0 );
         }
 
         Object newCredentials = authToken.get( NEW_CREDENTIALS );
-        if ( newCredentials != null && newCredentials instanceof byte[] )
+        if ( newCredentials instanceof byte[] )
         {
             Arrays.fill( (byte[]) newCredentials, (byte) 0 );
         }

diff --git a/...ty/src/main/java/org/neo4j/server/security/enterprise/auth/plugin/PluginApiAuthToken.java b/...ty/src/main/java/org/neo4j/server/security/enterprise/auth/plugin/PluginApiAuthToken.java
@@ -24,6 +24,7 @@
 
 import java.nio.ByteBuffer;
 import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
 import java.util.Map;
 
 import org.neo4j.kernel.api.security.exception.InvalidAuthTokenException;
@@ -64,12 +65,20 @@ public Map<String,Object> parameters()
         return parameters;
     }
 
-    public static AuthToken of( String principal, char[] credentials, Map<String,Object> parameters )
+    void clearCredentials()
+    {
+        if ( credentials != null )
+        {
+            Arrays.fill( credentials, (char) 0 );
+        }
+    }
+
+    public static PluginApiAuthToken of( String principal, char[] credentials, Map<String,Object> parameters )
     {
         return new PluginApiAuthToken( principal, credentials, parameters );
     }
 
-    public static AuthToken createFromMap( Map<String,Object> authTokenMap ) throws InvalidAuthTokenException
+    public static PluginApiAuthToken createFromMap( Map<String,Object> authTokenMap ) throws InvalidAuthTokenException
     {
         String scheme = org.neo4j.kernel.api.security.AuthToken
                 .safeCast( org.neo4j.kernel.api.security.AuthToken.SCHEME_KEY, authTokenMap );

diff --git a/.../security/src/main/java/org/neo4j/server/security/enterprise/auth/plugin/PluginRealm.java b/.../security/src/main/java/org/neo4j/server/security/enterprise/auth/plugin/PluginRealm.java
@@ -186,7 +186,7 @@ protected AuthenticationInfo doGetAuthenticationInfo( AuthenticationToken token
         {
             try
             {
-                AuthToken pluginAuthToken =
+                PluginApiAuthToken pluginAuthToken =
                         PluginApiAuthToken.createFromMap( ((ShiroAuthToken) token).getAuthTokenMap() );
                 try
                 {
@@ -216,7 +216,7 @@ else if ( authenticationPlugin != null )
                 finally
                 {
                     // Clear credentials
-                    Arrays.fill( pluginAuthToken.credentials(), (char) 0 );
+                    pluginAuthToken.clearCredentials();
                 }
             }
             catch ( org.neo4j.server.security.enterprise.auth.plugin.api.AuthenticationException |