-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #11459 from MishaDemianenko/3.4-allow-ongoing-cont…
…raint-indexes-in-cc Skip index verification for not completed constraints during the consistency check
- Loading branch information
Showing
6 changed files
with
150 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123 changes: 123 additions & 0 deletions
123
integrationtests/src/test/java/org/neo4j/consistency/HalfCreatedConstraintIT.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| /* | ||
| * Copyright (c) 2002-2018 "Neo Technology," | ||
| * Network Engine for Objects in Lund AB [http://neotechnology.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Neo4j is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as | ||
| * published by the Free Software Foundation, either version 3 of the | ||
| * License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| package org.neo4j.consistency; | ||
|
|
||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
|
|
||
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.io.PrintStream; | ||
| import java.nio.file.Files; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import org.neo4j.graphdb.GraphDatabaseService; | ||
| import org.neo4j.graphdb.Label; | ||
| import org.neo4j.graphdb.Node; | ||
| import org.neo4j.graphdb.Transaction; | ||
| import org.neo4j.graphdb.factory.EnterpriseGraphDatabaseFactory; | ||
| import org.neo4j.kernel.api.KernelTransaction; | ||
| import org.neo4j.kernel.api.schema.LabelSchemaDescriptor; | ||
| import org.neo4j.kernel.api.schema.SchemaDescriptorFactory; | ||
| import org.neo4j.kernel.api.schema.index.SchemaIndexDescriptor; | ||
| import org.neo4j.kernel.api.schema.index.SchemaIndexDescriptorFactory; | ||
| import org.neo4j.kernel.impl.api.KernelTransactionImplementation; | ||
| import org.neo4j.kernel.impl.core.ThreadToStatementContextBridge; | ||
| import org.neo4j.kernel.internal.GraphDatabaseAPI; | ||
| import org.neo4j.test.rule.TestDirectory; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.Assert.fail; | ||
|
|
||
| public class HalfCreatedConstraintIT | ||
| { | ||
| @Rule | ||
| public final TestDirectory testDirectory = TestDirectory.testDirectory(); | ||
|
|
||
| @Test | ||
| public void uniqueIndexWithoutOwningConstraintIsIgnoredDuringCheck() throws ConsistencyCheckTool.ToolFailureException, IOException | ||
| { | ||
| File storeDir = testDirectory.graphDbDir(); | ||
| Label marker = Label.label( "MARKER" ); | ||
| String property = "property"; | ||
|
|
||
| GraphDatabaseService database = new EnterpriseGraphDatabaseFactory().newEmbeddedDatabase( storeDir ); | ||
| try | ||
| { | ||
| createNodes( marker, property, database ); | ||
| addIndex( database ); | ||
| waitForIndexPopulationFailure( database ); | ||
| } | ||
| finally | ||
| { | ||
| database.shutdown(); | ||
| } | ||
|
|
||
| ConsistencyCheckService.Result checkResult = | ||
| ConsistencyCheckTool.runConsistencyCheckTool( new String[]{storeDir.getAbsolutePath()}, emptyPrintStream(), emptyPrintStream() ); | ||
| assertTrue( String.join( System.lineSeparator(), Files.readAllLines( checkResult.reportFile().toPath() ) ), checkResult.isSuccessful() ); | ||
| } | ||
|
|
||
| private void waitForIndexPopulationFailure( GraphDatabaseService database ) | ||
| { | ||
| try ( Transaction ignored = database.beginTx() ) | ||
| { | ||
| database.schema().awaitIndexesOnline( 10, TimeUnit.MINUTES ); | ||
| fail( "Unique index population should fail." ); | ||
| } | ||
| catch ( IllegalStateException e ) | ||
| { | ||
| assertEquals( "Index entered a FAILED state. Please see database logs.", e.getMessage() ); | ||
| } | ||
| } | ||
|
|
||
| private void addIndex( GraphDatabaseService database ) | ||
| { | ||
| try ( Transaction transaction = database.beginTx() ) | ||
| { | ||
| ThreadToStatementContextBridge statementBridge = | ||
| ((GraphDatabaseAPI) database).getDependencyResolver().provideDependency( ThreadToStatementContextBridge.class ).get(); | ||
| KernelTransaction kernelTransaction = statementBridge.getKernelTransactionBoundToThisThread( true ); | ||
| LabelSchemaDescriptor descriptor = SchemaDescriptorFactory.forLabel( 0, 0 ); | ||
| SchemaIndexDescriptor index = SchemaIndexDescriptorFactory.uniqueForSchema( descriptor ); | ||
| ((KernelTransactionImplementation) kernelTransaction).txState().indexRuleDoAdd( index ); | ||
| transaction.success(); | ||
| } | ||
| } | ||
|
|
||
| private void createNodes( Label marker, String property, GraphDatabaseService database ) | ||
| { | ||
| try ( Transaction transaction = database.beginTx() ) | ||
| { | ||
| for ( int i = 0; i < 10; i++ ) | ||
| { | ||
| Node node = database.createNode( marker ); | ||
| node.setProperty( property, "a" ); | ||
| } | ||
| transaction.success(); | ||
| } | ||
| } | ||
|
|
||
| private static PrintStream emptyPrintStream() | ||
| { | ||
| return new PrintStream( org.neo4j.io.NullOutputStream.NULL_OUTPUT_STREAM ); | ||
| } | ||
| } |