Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enforce composite uniqueness constraints
- Loading branch information
Showing
3 changed files
with
334 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
254 changes: 254 additions & 0 deletions
254
.../org/neo4j/kernel/impl/api/integrationtest/CompositeUniquenessConstraintValidationIT.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,254 @@ | ||
| /* | ||
| * Copyright (c) 2002-2017 "Neo Technology," | ||
| * Network Engine for Objects in Lund AB [http://neotechnology.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Neo4j is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| package org.neo4j.kernel.impl.api.integrationtest; | ||
|
|
||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
| import org.junit.rules.TestName; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.Parameterized; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Arrays; | ||
| import java.util.Map; | ||
|
|
||
| import org.neo4j.helpers.collection.Iterators; | ||
| import org.neo4j.helpers.collection.MapUtil; | ||
| import org.neo4j.kernel.api.Statement; | ||
| import org.neo4j.kernel.api.StatementTokenNameLookup; | ||
| import org.neo4j.kernel.api.TokenNameLookup; | ||
| import org.neo4j.kernel.api.exceptions.KernelException; | ||
| import org.neo4j.kernel.api.exceptions.schema.IllegalTokenNameException; | ||
| import org.neo4j.kernel.api.exceptions.schema.TooManyLabelsException; | ||
| import org.neo4j.kernel.api.exceptions.schema.UniquePropertyValueValidationException; | ||
| import org.neo4j.kernel.api.schema_new.index.NewIndexDescriptorFactory; | ||
| import org.neo4j.kernel.api.security.SecurityContext; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNotEquals; | ||
| import static org.junit.Assert.assertThat; | ||
| import static org.junit.Assert.fail; | ||
| import static org.neo4j.kernel.api.CompositeIndexingIT.LABEL_ID; | ||
| import static org.neo4j.kernel.api.properties.Property.property; | ||
| import static org.neo4j.kernel.api.schema_new.SchemaDescriptorFactory.forLabel; | ||
| import static org.neo4j.test.assertion.Assert.assertException; | ||
|
|
||
| @RunWith( Parameterized.class ) | ||
| public class CompositeUniquenessConstraintValidationIT extends KernelIntegrationTest | ||
| { | ||
| @Rule | ||
| public final TestName testName = new TestName(); | ||
|
|
||
| @Parameterized.Parameters( name = "Index: {0}" ) | ||
| public static Iterable<Object[]> parameterValues() throws IOException | ||
| { | ||
| return Arrays.<Object[]>asList( | ||
| Iterators.array( "v1", "v2", "v1", "v2" ), | ||
| Iterators.array( 10, 20, 10, 20 ), | ||
| Iterators.array( 10L, 20L, 10, 20 ), | ||
| Iterators.array( 10, 20, 10L, 20L ), | ||
| Iterators.array( 10, 20, 10.0, 20.0 ), | ||
| Iterators.array( new int[]{1,2}, "v2", new int[]{1,2}, "v2" ), | ||
| Iterators.array( 'v', "v2", "v", "v2" ) | ||
| ); | ||
| } | ||
|
|
||
| private static final String prop1 = "key1"; | ||
| private static final String prop2 = "key2"; | ||
| private static final String label = "Label1"; | ||
| private Statement statement; | ||
|
|
||
| private final Object valueA1; | ||
| private final Object valueA2; | ||
|
|
||
| private final Object valueB1; | ||
| private final Object valueB2; | ||
|
|
||
| public CompositeUniquenessConstraintValidationIT( Object valueA1, Object valueA2, Object valueB1, Object valueB2 ) | ||
| { | ||
| this.valueA1 = valueA1; | ||
| this.valueA2 = valueA2; | ||
| this.valueB1 = valueB1; | ||
| this.valueB2 = valueB2; | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldEnforceOnSetProperty() throws Exception | ||
| { | ||
| // given | ||
| constrainedNode( label, MapUtil.map( prop1, valueA1, prop2, valueA2 ) ); | ||
|
|
||
| // when | ||
| newTransaction(); | ||
| long node = createLabeledNode( label ); | ||
| assertException( () -> { | ||
| setProperty( node, prop1, valueB1 ); // still ok | ||
| setProperty( node, prop2, valueB2 ); // boom! | ||
|
|
||
| }, UniquePropertyValueValidationException.class, "" ); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldEnforceOnSetLabel() throws Exception | ||
| { | ||
| // given | ||
| constrainedNode( label, MapUtil.map( prop1, valueA1, prop2, valueA2 ) ); | ||
|
|
||
| // when | ||
| newTransaction(); | ||
| long node = createNode(); | ||
| assertException( () -> { | ||
| setProperty( node, prop1, valueB1 ); // still ok | ||
| setProperty( node, prop2, valueB2 ); // and fine | ||
| addLabel( node, label ); // boom again | ||
|
|
||
| }, UniquePropertyValueValidationException.class, "" ); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldEnforceOnSetPropertyInTx() throws Exception | ||
| { | ||
| // given | ||
| createConstraint( label, prop1, prop2 ); | ||
|
|
||
| // when | ||
| newTransaction(); | ||
| long nodeA = createLabeledNode( label ); | ||
| setProperty( nodeA, prop1, valueA1 ); | ||
| setProperty( nodeA, prop2, valueA2 ); | ||
|
|
||
| long nodeB = createLabeledNode( label ); | ||
| assertException( () -> { | ||
| setProperty( nodeB, prop1, valueB1 ); // still ok | ||
| setProperty( nodeB, prop2, valueB2 ); // boom! | ||
|
|
||
| }, UniquePropertyValueValidationException.class, "" ); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldEnforceOnSetLabelInTx() throws Exception | ||
| { | ||
| // given | ||
| createConstraint( label, prop1, prop2 ); | ||
|
|
||
| // when | ||
| newTransaction(); | ||
| long nodeA = createLabeledNode( label ); | ||
| setProperty( nodeA, prop1, valueA1 ); | ||
| setProperty( nodeA, prop2, valueA2 ); | ||
|
|
||
| long nodeB = createNode(); | ||
| assertException( () -> { | ||
| setProperty( nodeB, prop1, valueB1 ); // still ok | ||
| setProperty( nodeB, prop2, valueB2 ); // and fine | ||
| addLabel( nodeB, label ); // boom again | ||
|
|
||
| }, UniquePropertyValueValidationException.class, "" ); | ||
| } | ||
|
|
||
| private void newTransaction() throws KernelException | ||
| { | ||
| statement = statementInNewTransaction( SecurityContext.AUTH_DISABLED ); | ||
| } | ||
|
|
||
| private long createLabeledNode( String label ) throws KernelException | ||
| { | ||
| long node = statement.dataWriteOperations().nodeCreate(); | ||
| int labelId = statement.tokenWriteOperations().labelGetOrCreateForName( label ); | ||
| statement.dataWriteOperations().nodeAddLabel( node, labelId ); | ||
| return node; | ||
| } | ||
|
|
||
| private void addLabel( long nodeId, String label ) throws KernelException | ||
| { | ||
| addLabel( nodeId, getLabelId( label ) ); | ||
| } | ||
|
|
||
| private void addLabel( long nodeId, int labelId ) throws KernelException | ||
| { | ||
| statement.dataWriteOperations().nodeAddLabel( nodeId, labelId ); | ||
| } | ||
|
|
||
| private void setProperty( long nodeId, int propertyId, Object value ) throws KernelException | ||
| { | ||
| statement.dataWriteOperations().nodeSetProperty( nodeId, property( propertyId, value ) ); | ||
| } | ||
|
|
||
| private void setProperty( long nodeId, String propertyName, Object value ) throws KernelException | ||
| { | ||
| statement.dataWriteOperations().nodeSetProperty( nodeId, property( getPropertyId( propertyName ), value ) ); | ||
| } | ||
|
|
||
| private long createNode() throws KernelException | ||
| { | ||
| return statement.dataWriteOperations().nodeCreate(); | ||
| } | ||
|
|
||
| private long constrainedNode( String label, Map<String,Object> properties ) | ||
| throws KernelException | ||
| { | ||
| newTransaction(); | ||
| int labelId = getLabelId( label ); | ||
| long nodeId = createNode(); | ||
| addLabel( nodeId, labelId ); | ||
| for ( Map.Entry<String,Object> entry : properties.entrySet() ) | ||
| { | ||
| int propertyId = getPropertyId( entry.getKey() ); | ||
| setProperty( nodeId, propertyId, entry.getValue() ); | ||
| } | ||
| commit(); | ||
|
|
||
| createConstraint( label, properties.keySet().toArray( new String[0] ) ); | ||
| return nodeId; | ||
| } | ||
|
|
||
| private void createConstraint( String label, String... propertyNames ) throws KernelException | ||
| { | ||
| newTransaction(); | ||
| int labelId = getLabelId( label ); | ||
| int[] propertyIds = | ||
| Arrays.stream( propertyNames ) | ||
| .mapToInt( this::getPropertyId ) | ||
| .toArray(); | ||
|
|
||
| commit(); | ||
|
|
||
| newTransaction(); | ||
| statement.schemaWriteOperations().uniquePropertyConstraintCreate( forLabel( labelId, propertyIds ) ); | ||
| commit(); | ||
| } | ||
|
|
||
| private int getLabelId( String label ) throws IllegalTokenNameException, TooManyLabelsException | ||
| { | ||
| return statement.tokenWriteOperations().labelGetOrCreateForName( label ); | ||
| } | ||
|
|
||
| private int getPropertyId( String propertyName ) | ||
| { | ||
| try | ||
| { | ||
| return statement.tokenWriteOperations().propertyKeyGetOrCreateForName( propertyName ); | ||
| } | ||
| catch ( IllegalTokenNameException e ) | ||
| { | ||
| throw new RuntimeException( e ); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.