Added lastTransactionCommitTimestampWhenStarted to interface

neo4j · Jul 1, 2016 · 805197c · 805197c
1 parent dec2e48
commit 805197c
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/community/kernel/src/main/java/org/neo4j/kernel/api/KernelTransaction.java b/community/kernel/src/main/java/org/neo4j/kernel/api/KernelTransaction.java
@@ -124,6 +124,11 @@ interface CloseListener
      */
     void markForTermination( Status reason );
 
+    /**
+     * @return The timestamp of the last transaction that was committed to the store when this transaction started.
+     */
+    long lastTransactionTimestampWhenStarted();
+
     /**
      * Register a {@link CloseListener} to be invoked after commit, but before transaction events "after" hooks
      * are invoked.

diff --git a/...unity/kernel/src/main/java/org/neo4j/kernel/impl/api/KernelTransactionImplementation.java b/...unity/kernel/src/main/java/org/neo4j/kernel/impl/api/KernelTransactionImplementation.java
@@ -781,6 +781,7 @@ private boolean isTerminated()
         return terminationReason != null;
     }
 
+    @Override
     public long lastTransactionTimestampWhenStarted()
     {
         return lastTransactionTimestampWhenStarted;

diff --git a/...ernel/src/test/java/org/neo4j/kernel/impl/api/constraints/ConstraintIndexCreatorTest.java b/...ernel/src/test/java/org/neo4j/kernel/impl/api/constraints/ConstraintIndexCreatorTest.java
@@ -208,6 +208,12 @@ public void markForTermination( Status reason )
                 {
                 }
 
+                @Override
+                public long lastTransactionTimestampWhenStarted()
+                {
+                    return 0;
+                }
+
                 @Override
                 public void registerCloseListener( CloseListener listener )
                 {

diff --git a/...rise/com/src/main/java/org/neo4j/com/storecopy/TransactionCommittingResponseUnpacker.java b/...rise/com/src/main/java/org/neo4j/com/storecopy/TransactionCommittingResponseUnpacker.java
@@ -31,7 +31,6 @@
 import org.neo4j.kernel.api.KernelTransaction;
 import org.neo4j.kernel.api.exceptions.Status;
 import org.neo4j.kernel.impl.api.BatchingTransactionRepresentationStoreApplier;
-import org.neo4j.kernel.impl.api.KernelTransactionImplementation;
 import org.neo4j.kernel.impl.api.KernelTransactions;
 import org.neo4j.kernel.impl.api.TransactionRepresentationStoreApplier;
 import org.neo4j.kernel.impl.api.index.IndexUpdatesValidator;
@@ -401,8 +400,7 @@ private void markUnsafeTransactionsForTermination()
 
         for ( KernelTransaction tx : kernelTransactions.activeTransactions() )
         {
-            KernelTransactionImplementation kti = (KernelTransactionImplementation) tx;
-            long commitTimestamp = kti.lastTransactionTimestampWhenStarted();
+            long commitTimestamp = tx.lastTransactionTimestampWhenStarted();
 
             if ( commitTimestamp != TransactionIdStore.BASE_TX_COMMIT_TIMESTAMP &&
                  commitTimestamp < earliestSafeTimestamp )