Remove unnecessary synchronization

neo4j · Aug 25, 2016 · 82ef9cd · 82ef9cd
1 parent c637b8e
commit 82ef9cd
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/...dge/src/main/java/org/neo4j/coreedge/core/consensus/membership/RaftMembershipManager.java b/...dge/src/main/java/org/neo4j/coreedge/core/consensus/membership/RaftMembershipManager.java
@@ -30,10 +30,10 @@
 import org.neo4j.coreedge.core.consensus.log.RaftLogEntry;
 import org.neo4j.coreedge.core.consensus.log.ReadableRaftLog;
 import org.neo4j.coreedge.core.consensus.outcome.RaftLogCommand;
-import org.neo4j.coreedge.core.replication.SendToMyself;
 import org.neo4j.coreedge.core.consensus.roles.Role;
-import org.neo4j.coreedge.core.state.storage.StateStorage;
 import org.neo4j.coreedge.core.consensus.roles.follower.FollowerStates;
+import org.neo4j.coreedge.core.replication.SendToMyself;
+import org.neo4j.coreedge.core.state.storage.StateStorage;
 import org.neo4j.coreedge.identity.MemberId;
 import org.neo4j.kernel.lifecycle.LifecycleAdapter;
 import org.neo4j.logging.Log;
@@ -143,7 +143,7 @@ private void updateMemberSets()
         newReplicationMembers.addAll( additionalReplicationMembers );
 
         replicationMembers = newReplicationMembers;
-        notifyListeners();
+        listeners.forEach( Listener::onMembershipChanged );
     }
 
     /**
@@ -244,16 +244,11 @@ public Set<MemberId> replicationMembers()
     }
 
     @Override
-    public synchronized void registerListener( Listener listener )
+    public void registerListener( Listener listener )
     {
         listeners.add( listener );
     }
 
-    private synchronized void notifyListeners()
-    {
-        listeners.forEach( Listener::onMembershipChanged );
-    }
-
     boolean uncommittedMemberChangeInLog()
     {
         return state.uncommittedMemberChangeInLog();