Remove dead code, and other cleanups

Of note: The override of fillStackTrace in ReadPastEndException has been removed, because it's only initialised once, and its presence makes Class Hierarchy Analysis nervous about inlining it.

community/kernel/src/main/java/org/neo4j/kernel/NeoStoreDataSource.java

@@ -734,7 +734,8 @@ indexingService, alwaysCreateNewWriter( labelScanStore ), neoStore,
                 config.get( GraphDatabaseSettings.logical_log_rotation_threshold ), neoStore,
                 neoStore, physicalLogMonitor, transactionMetadataCache );
 
-        final PhysicalLogFileInformation.SPI logInformation = new PhysicalLogFileInformation.SPI()
+        final PhysicalLogFileInformation.LogVersionToTimestamp
+                logInformation = new PhysicalLogFileInformation.LogVersionToTimestamp()
         {
             @Override
             public long getTimestampForVersion( long version ) throws IOException

community/kernel/src/main/java/org/neo4j/kernel/impl/transaction/IllegalResourceException.java

@@ -21,23 +21,8 @@
 
 public class IllegalResourceException extends RuntimeException
 {
-    public IllegalResourceException()
-    {
-        super();
-    }
-
     public IllegalResourceException( String message )
     {
         super( message );
     }
-
-    public IllegalResourceException( String message, Throwable cause )
-    {
-        super( message, cause );
-    }
-
-    public IllegalResourceException( Throwable cause )
-    {
-        super( cause );
-    }
-}
+}

community/kernel/src/main/java/org/neo4j/kernel/impl/transaction/InjectedTransactionValidator.java

@@ -27,15 +27,5 @@
  */
 public interface InjectedTransactionValidator
 {
-    // This is used by the lucene data source, and some tests for convenience.
-    InjectedTransactionValidator ALLOW_ALL = new InjectedTransactionValidator(){
-
-        @Override
-        public void assertInjectionAllowed( long lastCommittedTxWhenTransactionStarted )
-        {
-            // Always ok.
-        }
-    };
-
     void assertInjectionAllowed( long lastCommittedTxWhenTransactionStarted ) throws TransactionFailureException;
 }

community/kernel/src/main/java/org/neo4j/kernel/impl/transaction/command/HighIdTransactionApplier.java

@@ -221,7 +221,7 @@ private void track( CommonAbstractStore store, long id )
         HighId highId = highIds.get( store );
         if ( highId == null )
         {
-            highIds.put( store, highId = new HighId( id ) );
+            highIds.put( store, new HighId( id ) );
         }
         else
         {