GenericKeyState cleanup: Read return boolean, copy also copies arrays…

…, more 1. GenericKeyState return boolean on read instead of initializing dummy value and let CompositeGenericKey do that instead. 2. copyFrom also copies array state if needed. 3. InitializeToDummy value also clear previous state. 4. initAsPrefix* does not clear because should have same behaviour as initValueAs*. 5. bytesDereferenced flag is not relevant for String array because byte arrays get deserialized into real String objects.
neo4j · Jul 27, 2018 · 95c9a04 · 95c9a04
1 parent c5735c3
commit 95c9a04
Show file tree

Hide file tree

Showing 2 changed files with 219 additions and 120 deletions.
diff --git a/community/kernel/src/main/java/org/neo4j/kernel/impl/index/schema/CompositeGenericKey.java b/community/kernel/src/main/java/org/neo4j/kernel/impl/index/schema/CompositeGenericKey.java
@@ -158,7 +158,11 @@ void read( PageCursor cursor, int keySize )
         int offset = cursor.getOffset();
         for ( GenericKeyState state : states )
         {
-            state.read( cursor, keySize );
+            if ( !state.read( cursor, keySize ) )
+            {
+                initializeToDummyValue();
+                return;
+            }
             int offsetAfterRead = cursor.getOffset();
             keySize -= offsetAfterRead - offset;
             offset = offsetAfterRead;