Skip to content

Commit

Permalink
Update cypher compiler dependencies to 3.3.3
Browse files Browse the repository at this point in the history
  • Loading branch information
Lojjs committed Feb 14, 2018
1 parent 30dbf66 commit 994b9cf
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 11 deletions.
2 changes: 1 addition & 1 deletion community/cypher/cypher/pom.xml
Expand Up @@ -217,7 +217,7 @@
<dependency>
<groupId>org.neo4j</groupId>
<artifactId>neo4j-cypher-compiler-3.3</artifactId>
<version>3.3.2</version>
<version>3.3.3</version>
<exclusions>
<exclusion>
<groupId>org.neo4j</groupId>
Expand Down
Expand Up @@ -2771,8 +2771,7 @@ class EagerizationAcceptanceTest
|RETURN size(tags) as nbrTags
""".stripMargin

// Fixed in 3.3.3
val nonBugFixedConfig = Configs.Version3_3 + Configs.Cost3_1
val nonBugFixedConfig = Configs.Cost3_1

val result = executeWith(Configs.UpdateConf - Configs.AllRulePlanners, query,
planComparisonStrategy = testEagerPlanComparisonStrategy(1, nonBugFixedConfig),
Expand All @@ -2794,8 +2793,7 @@ class EagerizationAcceptanceTest
|RETURN COUNT(t.value) as nbrTags
""".stripMargin

// Fixed in 3.3.3
val nonBugFixedConfig = Configs.Version3_3 + Configs.Cost3_1 + Configs.AllRulePlanners
val nonBugFixedConfig = Configs.Cost3_1 + Configs.AllRulePlanners

val result = executeWith(Configs.UpdateConf, query,
planComparisonStrategy = testEagerPlanComparisonStrategy(2, nonBugFixedConfig),
Expand Down
Expand Up @@ -44,10 +44,11 @@ class HintAcceptanceTest
|USING JOIN ON a
|RETURN a.name, b.name""".stripMargin

executeWith(Configs.Interpreted - Configs.Cost2_3 - Configs.Cost3_1, query, planComparisonStrategy = ComparePlansWithAssertion((p) => {
executeWith(Configs.Interpreted + Configs.Version3_3 - Configs.Cost2_3 - Configs.Cost3_1, query,
planComparisonStrategy = ComparePlansWithAssertion((p) => {
p should useOperators("NodeLeftOuterHashJoin")
p should not(useOperators("NodeHashJoin"))
}, expectPlansToFail = Configs.AllRulePlanners + Configs.BackwardsCompatibility))
}, expectPlansToFail = Configs.OldAndRule))
}

test("should not plan multiple joins for one hint - right outer join") {
Expand Down
Expand Up @@ -46,8 +46,7 @@ class MiscAcceptanceTest extends ExecutionEngineFunSuite with CypherComparisonSu
|ORDER BY y
""".stripMargin

// Fixed in 3.3.3
val result = executeWith(Configs.All, query, expectedDifferentResults = Configs.BackwardsCompatibility + Configs.AllRulePlanners)
val result = executeWith(Configs.All, query, expectedDifferentResults = Configs.OldAndRule)
result.toList should equal(List(Map("y" -> 1, "y3" -> 3), Map("y" -> 1, "y3" -> 4), Map("y" -> 2, "y3" -> 3), Map("y" -> 2, "y3" -> 4)))
}

Expand Down
Expand Up @@ -34,8 +34,7 @@ class RemoveAcceptanceTest extends ExecutionEngineFunSuite with QueryStatisticsT
|REMOVE CASE WHEN a.age>b.age THEN a ELSE b END.age
|RETURN a.age, b.age""".stripMargin

// Fixed in 3.3.3
val result = executeWith(Configs.UpdateConf - Configs.Version3_3 - Configs.Cost3_1, query)
val result = executeWith(Configs.UpdateConf - Configs.Cost3_1, query)

// then
result.toList should equal(List(Map("a.age" -> 23, "b.age" -> null)))
Expand Down

0 comments on commit 994b9cf

Please sign in to comment.