Removing Bolt V1 and Bolt V2

When tx failed with error, no more tx or query is allowed until the failure is cleared with a RESET message.
The client is not expected to continue a failed tx, as the tx can only be rolled back.
One of the main goal of this PR is to get rid of `ACK_FAILURE` message so that no more interaction is allowed with the tx after it is failed.

community/bolt/src/main/java/org/neo4j/bolt/BoltServer.java

@@ -26,13 +26,13 @@
 
 import org.neo4j.bolt.dbapi.BoltGraphDatabaseManagementServiceSPI;
 import org.neo4j.bolt.runtime.BoltConnectionFactory;
-import org.neo4j.bolt.runtime.BoltSchedulerProvider;
-import org.neo4j.bolt.runtime.BoltStateMachineFactory;
-import org.neo4j.bolt.runtime.BoltStateMachineFactoryImpl;
-import org.neo4j.bolt.runtime.CachedThreadPoolExecutorFactory;
+import org.neo4j.bolt.runtime.scheduling.BoltSchedulerProvider;
+import org.neo4j.bolt.runtime.statemachine.BoltStateMachineFactory;
+import org.neo4j.bolt.runtime.statemachine.impl.BoltStateMachineFactoryImpl;
+import org.neo4j.bolt.runtime.scheduling.CachedThreadPoolExecutorFactory;
 import org.neo4j.bolt.runtime.DefaultBoltConnectionFactory;
-import org.neo4j.bolt.runtime.ExecutorBoltSchedulerProvider;
-import org.neo4j.bolt.runtime.NettyThreadFactory;
+import org.neo4j.bolt.runtime.scheduling.ExecutorBoltSchedulerProvider;
+import org.neo4j.bolt.runtime.scheduling.NettyThreadFactory;
 import org.neo4j.bolt.security.auth.Authentication;
 import org.neo4j.bolt.security.auth.BasicAuthentication;
 import org.neo4j.bolt.transport.BoltProtocolFactory;
@@ -115,7 +115,7 @@ public void init() throws Exception
                 life.setLast( new ExecutorBoltSchedulerProvider( config, new CachedThreadPoolExecutorFactory( log ), jobScheduler, logService ) );
         BoltConnectionFactory boltConnectionFactory =
                 createConnectionFactory( config, boltSchedulerProvider, throttleGroup, logService, clock );
-        BoltStateMachineFactory boltStateMachineFactory = createBoltFactory( authentication, clock );
+        BoltStateMachineFactory boltStateMachineFactory = createBoltStateMachineFactory( authentication, clock );
 
         BoltProtocolFactory boltProtocolFactory = createBoltProtocolFactory( boltConnectionFactory, boltStateMachineFactory );
 
@@ -223,7 +223,7 @@ private BoltProtocolFactory createBoltProtocolFactory( BoltConnectionFactory con
         return new DefaultBoltProtocolFactory( connectionFactory, stateMachineFactory, logService, databaseIdRepository );
     }
 
-    private BoltStateMachineFactory createBoltFactory( Authentication authentication, SystemNanoClock clock )
+    private BoltStateMachineFactory createBoltStateMachineFactory( Authentication authentication, SystemNanoClock clock )
     {
         return new BoltStateMachineFactoryImpl( boltGraphDatabaseManagementServiceSPI, authentication, clock, config, logService );
     }

community/bolt/src/main/java/org/neo4j/bolt/messaging/BoltRequestMessageReader.java

@@ -23,10 +23,11 @@
 import java.util.List;
 import java.util.Map;
 
+import org.neo4j.bolt.packstream.Neo4jPack;
 import org.neo4j.bolt.runtime.BoltConnection;
 import org.neo4j.bolt.runtime.BoltResponseHandler;
 import org.neo4j.bolt.runtime.Neo4jError;
-import org.neo4j.bolt.v1.packstream.PackStream;
+import org.neo4j.bolt.packstream.PackStream;
 import org.neo4j.kernel.api.exceptions.Status;
 
 import static java.util.function.Function.identity;

community/bolt/src/main/java/org/neo4j/bolt/messaging/BoltResponseMessageWriter.java

@@ -28,4 +28,5 @@
 public interface BoltResponseMessageWriter extends BoltRecordConsumer
 {
     void write( ResponseMessage message ) throws IOException;
+    void flush() throws IOException;
 }

community/bolt/src/main/java/org/neo4j/bolt/messaging/RequestMessageDecoder.java

@@ -21,6 +21,7 @@
 
 import java.io.IOException;
 
+import org.neo4j.bolt.packstream.Neo4jPack;
 import org.neo4j.bolt.runtime.BoltResponseHandler;
 
 public interface RequestMessageDecoder

community/bolt/src/main/java/org/neo4j/bolt/messaging/ResponseMessageEncoder.java

@@ -21,6 +21,8 @@
 
 import java.io.IOException;
 
+import org.neo4j.bolt.packstream.Neo4jPack;
+
 public interface ResponseMessageEncoder<T extends ResponseMessage>
 {
     void encode( Neo4jPack.Packer packer, T message ) throws IOException;

community/bolt/src/main/java/org/neo4j/bolt/v4/messaging/ResultConsumer.java → community/bolt/src/main/java/org/neo4j/bolt/messaging/ResultConsumer.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v4.messaging;
+package org.neo4j.bolt.messaging;
 
 import org.neo4j.bolt.runtime.BoltResult;
 

community/bolt/src/main/java/org/neo4j/bolt/messaging/StructType.java

@@ -22,8 +22,8 @@
 import java.util.HashMap;
 import java.util.Map;
 
-import org.neo4j.bolt.v1.messaging.Neo4jPackV1;
-import org.neo4j.bolt.v2.messaging.Neo4jPackV2;
+import org.neo4j.bolt.packstream.Neo4jPackV1;
+import org.neo4j.bolt.packstream.Neo4jPackV2;
 
 import static java.util.Collections.unmodifiableMap;
 

community/bolt/src/main/java/org/neo4j/bolt/v1/packstream/ByteBufInput.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/ByteBufInput.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.packstream;
+package org.neo4j.bolt.packstream;
 
 import io.netty.buffer.ByteBuf;
 

community/bolt/src/main/java/org/neo4j/bolt/v1/transport/ChunkedOutput.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/ChunkedOutput.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.transport;
+package org.neo4j.bolt.packstream;
 
 import io.netty.buffer.ByteBuf;
 import io.netty.channel.Channel;
@@ -29,9 +29,6 @@
 import org.neo4j.bolt.messaging.BoltIOException;
 import org.neo4j.bolt.transport.TransportThrottleException;
 import org.neo4j.bolt.transport.TransportThrottleGroup;
-import org.neo4j.bolt.v1.packstream.PackOutput;
-import org.neo4j.bolt.v1.packstream.PackOutputClosedException;
-import org.neo4j.bolt.v1.packstream.PackStream;
 import org.neo4j.kernel.api.exceptions.Status;
 
 /**

community/bolt/src/main/java/org/neo4j/bolt/messaging/Neo4jPack.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/Neo4jPack.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.messaging;
+package org.neo4j.bolt.packstream;
 
 import java.io.IOException;
 

community/bolt/src/main/java/org/neo4j/bolt/v1/messaging/Neo4jPackV1.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/Neo4jPackV1.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.messaging;
+package org.neo4j.bolt.packstream;
 
 import java.io.IOException;
 import java.time.LocalDate;
@@ -29,13 +29,8 @@
 import java.util.List;
 
 import org.neo4j.bolt.messaging.BoltIOException;
-import org.neo4j.bolt.messaging.Neo4jPack;
 import org.neo4j.bolt.messaging.StructType;
 import org.neo4j.bolt.messaging.util.PrimitiveLongIntKeyValueArray;
-import org.neo4j.bolt.v1.packstream.PackInput;
-import org.neo4j.bolt.v1.packstream.PackOutput;
-import org.neo4j.bolt.v1.packstream.PackStream;
-import org.neo4j.bolt.v1.packstream.PackType;
 import org.neo4j.kernel.api.exceptions.Status;
 import org.neo4j.values.AnyValue;
 import org.neo4j.values.AnyValueWriter;
@@ -50,7 +45,7 @@
 import org.neo4j.values.virtual.RelationshipValue;
 import org.neo4j.values.virtual.VirtualValues;
 
-import static org.neo4j.bolt.v1.packstream.PackStream.UNKNOWN_SIZE;
+import static org.neo4j.bolt.packstream.PackStream.UNKNOWN_SIZE;
 import static org.neo4j.values.storable.Values.byteArray;
 
 /**

community/bolt/src/main/java/org/neo4j/bolt/v2/messaging/Neo4jPackV2.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/Neo4jPackV2.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v2.messaging;
+package org.neo4j.bolt.packstream;
 
 import java.io.IOException;
 import java.time.Instant;
@@ -31,12 +31,7 @@
 import java.util.Arrays;
 
 import org.neo4j.bolt.messaging.BoltIOException;
-import org.neo4j.bolt.messaging.Neo4jPack;
 import org.neo4j.bolt.messaging.StructType;
-import org.neo4j.bolt.v1.messaging.Neo4jPackV1;
-import org.neo4j.bolt.v1.packstream.PackInput;
-import org.neo4j.bolt.v1.packstream.PackOutput;
-import org.neo4j.bolt.v1.packstream.PackStream;
 import org.neo4j.kernel.api.exceptions.Status;
 import org.neo4j.values.AnyValue;
 import org.neo4j.values.storable.CoordinateReferenceSystem;

community/bolt/src/main/java/org/neo4j/bolt/v1/packstream/PackInput.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/PackInput.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.packstream;
+package org.neo4j.bolt.packstream;
 
 import java.io.IOException;
 

community/bolt/src/main/java/org/neo4j/bolt/v1/packstream/PackOutput.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/PackOutput.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.packstream;
+package org.neo4j.bolt.packstream;
 
 import java.io.Closeable;
 import java.io.IOException;

community/bolt/src/main/java/org/neo4j/bolt/v1/packstream/PackOutputClosedException.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/PackOutputClosedException.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.packstream;
+package org.neo4j.bolt.packstream;
 
 import java.io.IOException;
 

community/bolt/src/main/java/org/neo4j/bolt/messaging/PackProvider.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/PackProvider.java

@@ -17,9 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.messaging;
-
-import org.neo4j.bolt.v1.packstream.PackOutput;
+package org.neo4j.bolt.packstream;
 
 public interface PackProvider
 {

community/bolt/src/main/java/org/neo4j/bolt/v1/packstream/PackStream.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/PackStream.java

@@ -17,14 +17,14 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.packstream;
+package org.neo4j.bolt.packstream;
 
 import java.io.IOException;
 import java.nio.ByteBuffer;
 import java.nio.charset.StandardCharsets;
 
 import org.neo4j.bolt.messaging.StructType;
-import org.neo4j.bolt.v1.packstream.utf8.UTF8Encoder;
+import org.neo4j.bolt.packstream.utf8.UTF8Encoder;
 
 /**
  * PackStream is a messaging serialisation format heavily inspired by MessagePack.

community/bolt/src/main/java/org/neo4j/bolt/v1/packstream/PackType.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/PackType.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.packstream;
+package org.neo4j.bolt.packstream;
 
 /**
  * These are the primitive types that PackStream can represent. They map to the non-graph primitives of the Neo4j

community/bolt/src/main/java/org/neo4j/bolt/v1/packstream/PackedInputArray.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/PackedInputArray.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.packstream;
+package org.neo4j.bolt.packstream;
 
 import java.io.ByteArrayInputStream;
 import java.io.DataInputStream;

community/bolt/src/main/java/org/neo4j/bolt/messaging/UnpackerProvider.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/UnpackerProvider.java

@@ -17,9 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.messaging;
-
-import org.neo4j.bolt.v1.packstream.PackInput;
+package org.neo4j.bolt.packstream;
 
 public interface UnpackerProvider
 {

community/bolt/src/main/java/org/neo4j/bolt/v1/packstream/utf8/GCFreeUTF8Encoder.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/utf8/GCFreeUTF8Encoder.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.packstream.utf8;
+package org.neo4j.bolt.packstream.utf8;
 
 import java.lang.invoke.MethodHandle;
 import java.lang.invoke.MethodHandles;
@@ -27,7 +27,7 @@
 import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
 
-import org.neo4j.bolt.v1.packstream.PackStream.PackStreamException;
+import org.neo4j.bolt.packstream.PackStream.PackStreamException;
 import org.neo4j.common.HexPrinter;
 
 import static org.neo4j.util.FeatureToggles.getInteger;

community/bolt/src/main/java/org/neo4j/bolt/v1/packstream/utf8/UTF8Encoder.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/utf8/UTF8Encoder.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.packstream.utf8;
+package org.neo4j.bolt.packstream.utf8;
 
 import java.nio.ByteBuffer;
 
@@ -63,7 +63,7 @@ public UTF8Encoder fastestAvailableEncoder()
             try
             {
                 return (UTF8Encoder)Class
-                        .forName( "org.neo4j.bolt.v1.packstream.utf8.GCFreeUTF8Encoder" )
+                        .forName( "org.neo4j.bolt.packstream.utf8.GCFreeUTF8Encoder" )
                         .getConstructor()
                         .newInstance();
             }

community/bolt/src/main/java/org/neo4j/bolt/v1/packstream/utf8/VanillaUTF8Encoder.java → community/bolt/src/main/java/org/neo4j/bolt/packstream/utf8/VanillaUTF8Encoder.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.packstream.utf8;
+package org.neo4j.bolt.packstream.utf8;
 
 import java.nio.ByteBuffer;
 import java.nio.charset.StandardCharsets;

community/bolt/src/main/java/org/neo4j/bolt/v1/runtime/CypherAdapterStream.java → community/bolt/src/main/java/org/neo4j/bolt/runtime/AbstractCypherAdapterStream.java

@@ -17,14 +17,14 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.bolt.v1.runtime;
+package org.neo4j.bolt.runtime;
 
 import java.time.Clock;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 
-import org.neo4j.bolt.runtime.BoltResult;
+import org.neo4j.bolt.runtime.statemachine.impl.BoltAdapterSubscriber;
 import org.neo4j.graphdb.ExecutionPlanDescription;
 import org.neo4j.graphdb.InputPosition;
 import org.neo4j.graphdb.Notification;
@@ -41,12 +41,10 @@
 import static java.lang.String.format;
 import static org.neo4j.bolt.v4.messaging.AbstractStreamingMessage.STREAM_LIMIT_UNLIMITED;
 import static org.neo4j.values.storable.Values.intValue;
-import static org.neo4j.values.storable.Values.longValue;
 import static org.neo4j.values.storable.Values.stringValue;
 
-public class CypherAdapterStream implements BoltResult
+public abstract class AbstractCypherAdapterStream implements BoltResult
 {
-    private static final String RESULT_CONSUMED_AFTER = "result_consumed_after";
     private static final String TYPE = "type";
     private static final String STATS = "stats";
     private static final String PROFILE = "profile";
@@ -60,12 +58,12 @@ public class CypherAdapterStream implements BoltResult
     private final QueryExecution queryExecution;
     private final String[] fieldNames;
     protected final Clock clock;
-    private final TransactionStateMachineV1SPI.BoltAdapterSubscriber querySubscriber;
+    private final BoltAdapterSubscriber querySubscriber;
 
     private static final Long STREAM_UNLIMITED_BATCH_SIZE = Long.MAX_VALUE;
 
-    public CypherAdapterStream( QueryExecution queryExecution,
-            TransactionStateMachineV1SPI.BoltAdapterSubscriber querySubscriber, Clock clock )
+    public AbstractCypherAdapterStream( QueryExecution queryExecution,
+            BoltAdapterSubscriber querySubscriber, Clock clock )
     {
         this.queryExecution = queryExecution;
         this.fieldNames = queryExecution.fieldNames();
@@ -117,14 +115,9 @@ public boolean handleRecords( RecordConsumer recordConsumer, long size ) throws
         return hasMore;
     }
 
-    protected void addDatabaseName( RecordConsumer recordConsumer )
-    {
-    }
+    protected abstract void addDatabaseName( RecordConsumer recordConsumer );
 
-    protected void addRecordStreamingTime( long time, RecordConsumer recordConsumer )
-    {
-        recordConsumer.addMetadata( RESULT_CONSUMED_AFTER, longValue( time ) );
-    }
+    protected abstract void addRecordStreamingTime( long time, RecordConsumer recordConsumer );
 
     private void addMetadata( QueryStatistics statistics, RecordConsumer recordConsumer )
     {

community/bolt/src/main/java/org/neo4j/bolt/runtime/BoltConnection.java

@@ -24,8 +24,7 @@
 import java.net.SocketAddress;
 import java.util.concurrent.RejectedExecutionException;
 
-import org.neo4j.bolt.v1.packstream.PackOutput;
-import org.neo4j.bolt.v1.runtime.Job;
+import org.neo4j.bolt.packstream.PackOutput;
 
 public interface BoltConnection
 {

community/bolt/src/main/java/org/neo4j/bolt/runtime/BoltConnectionFactory.java

@@ -20,6 +20,7 @@
 package org.neo4j.bolt.runtime;
 
 import org.neo4j.bolt.BoltChannel;
+import org.neo4j.bolt.runtime.statemachine.BoltStateMachine;
 
 public interface BoltConnectionFactory
 {