-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #7410 from systay/3.0-cached-in
Improve the performance of IN checking
- Loading branch information
Showing
27 changed files
with
988 additions
and
267 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -101,4 +101,3 @@ case class ExecutionContext(m: MutableMap[String, Any] = MutableMaps.empty) | |
copy(m = newMap) | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
.../src/main/scala/org/neo4j/cypher/internal/compiler/v3_0/commands/predicates/Checker.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
/* | ||
* Copyright (c) 2002-2016 "Neo Technology," | ||
* Network Engine for Objects in Lund AB [http://neotechnology.com] | ||
* | ||
* This file is part of Neo4j. | ||
* | ||
* Neo4j is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
package org.neo4j.cypher.internal.compiler.v3_0.commands.predicates | ||
|
||
import scala.collection.mutable | ||
|
||
/** | ||
* This is a class that handles IN checking. With a cache. It's a state machine, and | ||
* each checking using the contains() method returns both the result of the IN check and the new state. | ||
*/ | ||
trait Checker { | ||
def contains(value: Any): (Option[Boolean], Checker) | ||
} | ||
|
||
class BuildUp(iterator: Iterator[Any]) extends Checker { | ||
private val cachedSet: mutable.Set[Equivalent] = new mutable.HashSet[Equivalent] | ||
private var falseResult: Option[Boolean] = Some(false) | ||
|
||
assert(iterator.nonEmpty) | ||
|
||
override def contains(value: Any): (Option[Boolean], Checker) = { | ||
if (value == null) | ||
return (None, this) | ||
|
||
val eqValue = Equivalent(value) | ||
if (cachedSet.contains(eqValue)) | ||
(Some(true), this) | ||
else | ||
checkAndBuildUpCache(value) | ||
} | ||
|
||
private def checkAndBuildUpCache(value: Any): (Option[Boolean], Checker) = { | ||
while (iterator.nonEmpty) { | ||
val nextValue = iterator.next() | ||
|
||
if (nextValue == null) { | ||
falseResult = None | ||
} else { | ||
val next = Equivalent(nextValue) | ||
cachedSet.add(next) | ||
val result = next == value | ||
if (result) return (Some(true), this) | ||
} | ||
} | ||
|
||
(falseResult, new SetChecker(cachedSet, falseResult)) | ||
} | ||
} | ||
|
||
case object AlwaysFalseChecker extends Checker { | ||
override def contains(value: Any): (Option[Boolean], Checker) = (Some(false), this) | ||
} | ||
|
||
case object NullListChecker extends Checker { | ||
override def contains(value: Any): (Option[Boolean], Checker) = (None, this) | ||
} | ||
|
||
// This is the final form for this cache. | ||
class SetChecker(cachedSet: mutable.Set[Equivalent], falseResult: Option[Boolean]) extends Checker { | ||
|
||
assert(cachedSet.nonEmpty) | ||
|
||
override def contains(value: Any): (Option[Boolean], Checker) = { | ||
if (value == null) | ||
return (None, this) | ||
|
||
val eqValue = Equivalent(value) | ||
|
||
val exists = cachedSet.contains(eqValue) | ||
val result = if (exists) Some(true) else falseResult | ||
(result, this) | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.