Support for adding relationship to explicit index

neo4j · Feb 23, 2018 · b9f1dcb · b9f1dcb
1 parent c7bf38b
commit b9f1dcb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/...el-api/src/test/java/org/neo4j/internal/kernel/api/ExplicitIndexCursorWritesTestBase.java b/...el-api/src/test/java/org/neo4j/internal/kernel/api/ExplicitIndexCursorWritesTestBase.java
@@ -19,7 +19,6 @@
  */
 package org.neo4j.internal.kernel.api;
 
-import org.junit.Ignore;
 import org.junit.Test;
 
 import java.util.HashMap;
@@ -265,7 +264,7 @@ public void shouldCreateExplicitIndexTwice() throws Exception
     }
 
     //TODO unignore when we support relationship creation.
-    @Ignore
+    @Test
     public void shouldAddRelationshipToExplicitIndex() throws Exception
     {
         long relId;

diff --git a/community/kernel/src/main/java/org/neo4j/kernel/impl/newapi/Operations.java b/community/kernel/src/main/java/org/neo4j/kernel/impl/newapi/Operations.java
@@ -537,8 +537,19 @@ public void nodeExplicitIndexCreateLazily( String indexName, Map<String,String>
 
     @Override
     public void relationshipAddToExplicitIndex( String indexName, long relationship, String key, Object value )
+            throws KernelException
     {
-        throw new UnsupportedOperationException(  );
+        ktx.assertOpen();
+        allStoreHolder.singleRelationship( relationship, relationshipCursor );
+        if ( relationshipCursor.next() )
+        {
+            ktx.explicitIndexTxState().relationshipChanges( indexName ).addRelationship( relationship, key, value,
+                    relationshipCursor.sourceNodeReference(), relationshipCursor.targetNodeReference() ) ;
+        }
+        else
+        {
+            throw new EntityNotFoundException( EntityType.RELATIONSHIP, relationship );
+        }
     }
 
     @Override