Improved Names and testing after review.

neo4j · Feb 21, 2017 · c2688cf · c2688cf
1 parent 9c987e5
commit c2688cf
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/community/kernel/src/main/java/org/neo4j/kernel/impl/proc/ProcedureTransactionProvider.java b/community/kernel/src/main/java/org/neo4j/kernel/impl/proc/ProcedureTransactionProvider.java
@@ -27,7 +27,6 @@
 
 import static org.neo4j.kernel.api.proc.Context.KERNEL_TRANSACTION;
 
-
 public class ProcedureTransactionProvider implements ComponentRegistry.Provider<ProcedureTransaction>
 {
     @Override

diff --git a/community/kernel/src/main/java/org/neo4j/procedure/ProcedureTransaction.java b/community/kernel/src/main/java/org/neo4j/procedure/ProcedureTransaction.java
@@ -50,6 +50,8 @@ public interface ProcedureTransaction
      * this method has been invoked, it doesn't matter if
      * {@link Transaction#success()} is invoked afterwards -- the transaction will still be
      * rolled back.
+     *
+     * This method is not thread safe.
      */
     void failure();
 }
diff --git a/integrationtests/src/test/java/org/neo4j/procedure/ProcedureIT.java b/integrationtests/src/test/java/org/neo4j/procedure/ProcedureIT.java
@@ -1130,7 +1130,7 @@ public void shouldMakeTransactionToFail() throws Throwable
         {
             db.createNode( Label.label( "Person" ) );
         }
-        Result result = db.execute( "CALL org.neo4j.procedure.failure" );
+        Result result = db.execute( "CALL org.neo4j.procedure.failingPersonCount" );
         //Then
         exception.expect( TransactionFailureException.class );
         result.next();
@@ -1145,7 +1145,6 @@ public void setUp() throws IOException
         db = new TestGraphDatabaseFactory()
                 .newImpermanentDatabaseBuilder()
                 .setConfig( plugin_dir, plugins.getRoot().getAbsolutePath() )
-                .setConfig( procedure_unrestricted, "org.neo4j.procedure.*" )
                 .newGraphDatabase();
     }
 
@@ -1302,7 +1301,7 @@ public Stream<Output> integrationTestMe()
         }
 
         @Procedure
-        public Stream<Output> failure()
+        public Stream<Output> failingPersonCount()
         {
             Result result = db.execute( "MATCH (n:Person) RETURN count(n) as count" );
             procedureTransaction.failure();