Skip to content

Commit

Permalink
Do not store (unused) property changes data in tx state
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrei Koval committed Mar 20, 2018
1 parent f2fe725 commit c87d945
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 172 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ public class TxState implements TransactionState, RelationshipVisitor.Home
private DiffSets<SchemaIndexDescriptor> indexChanges;
private DiffSets<ConstraintDescriptor> constraintsChanges;

private PropertyChanges propertyChangesForNodes;

private RemovalsCountingDiffSets nodes;
private RemovalsCountingRelationshipsDiffSets relationships;

Expand Down Expand Up @@ -531,15 +529,13 @@ public void nodeDoAddProperty( long nodeId, int newPropertyKeyId, Value value )
{
NodeStateImpl nodeState = getOrCreateNodeState( nodeId );
nodeState.addProperty( newPropertyKeyId, value );
nodePropertyChanges().addProperty( nodeId, newPropertyKeyId, value );
dataChanged();
}

@Override
public void nodeDoChangeProperty( long nodeId, int propertyKeyId, Value replacedValue, Value newValue )
{
getOrCreateNodeState( nodeId ).changeProperty( propertyKeyId, newValue );
nodePropertyChanges().changeProperty( nodeId, propertyKeyId, replacedValue, newValue );
dataChanged();
}

Expand Down Expand Up @@ -576,7 +572,6 @@ public void graphDoReplaceProperty( int propertyKeyId, Value replacedValue, Valu
public void nodeDoRemoveProperty( long nodeId, int propertyKeyId, Value removedValue )
{
getOrCreateNodeState( nodeId ).removeProperty( propertyKeyId, removedValue );
nodePropertyChanges().removeProperty( nodeId, propertyKeyId, removedValue );
dataChanged();
}

Expand Down Expand Up @@ -1229,11 +1224,6 @@ private boolean hasNodeState( long nodeId )
return nodeStatesMap != null && nodeStatesMap.containsKey( nodeId );
}

private PropertyChanges nodePropertyChanges()
{
return propertyChangesForNodes == null ? propertyChangesForNodes = new PropertyChanges( collectionsFactory ) : propertyChangesForNodes;
}

@Override
public PrimitiveLongResourceIterator augmentNodesGetAll( PrimitiveLongIterator committed )
{
Expand Down Expand Up @@ -1287,10 +1277,6 @@ public void release()
{
relationshipStatesMap.close();
}
if ( propertyChangesForNodes != null )
{
propertyChangesForNodes.release();
}
if ( nodes != null && nodes.removedFromAdded != null )
{
nodes.removedFromAdded.close();
Expand Down

This file was deleted.

0 comments on commit c87d945

Please sign in to comment.