Remove label scan store selection strategies

Since there is only one label scan store provider left
there is no need to select at all.

Remove
 - NamedLabelScanStoreSelectionStrategy
 - DeleteStoresFromOtherLabelScanStoreProviders

community/consistency-check/src/main/java/org/neo4j/consistency/ConsistencyCheckService.java

@@ -51,7 +51,6 @@
 import org.neo4j.kernel.extension.KernelExtensionFactory;
 import org.neo4j.kernel.extension.KernelExtensions;
 import org.neo4j.kernel.extension.dependency.HighestSelectionStrategy;
-import org.neo4j.kernel.extension.dependency.NamedLabelScanStoreSelectionStrategy;
 import org.neo4j.kernel.impl.api.index.IndexStoreView;
 import org.neo4j.kernel.impl.api.scan.LabelScanStoreProvider;
 import org.neo4j.kernel.impl.locking.LockService;
@@ -247,8 +246,7 @@ public Result runFullConsistencyCheck( final File storeDir, Config config, Progr
             KernelExtensions extensions = life.add( new KernelExtensions(
                     kernelContext, (Iterable) load( KernelExtensionFactory.class ), dependencies, ignore() ) );
             life.start();
-            LabelScanStore labelScanStore = life.add( extensions.resolveDependency( LabelScanStoreProvider.class,
-                    new NamedLabelScanStoreSelectionStrategy( config ) ).getLabelScanStore() );
+            LabelScanStore labelScanStore = life.add( extensions.resolveDependency( LabelScanStoreProvider.class ).getLabelScanStore() );
             SchemaIndexProvider indexes = life.add( extensions.resolveDependency( SchemaIndexProvider.class,
                     HighestSelectionStrategy.getInstance() ) );
 

community/consistency-check/src/test/java/org/neo4j/consistency/checking/GraphStoreFixture.java

@@ -52,7 +52,6 @@
 import org.neo4j.kernel.configuration.Config;
 import org.neo4j.kernel.extension.KernelExtensionFactory;
 import org.neo4j.kernel.extension.KernelExtensions;
-import org.neo4j.kernel.extension.dependency.NamedLabelScanStoreSelectionStrategy;
 import org.neo4j.kernel.impl.api.TransactionRepresentationCommitProcess;
 import org.neo4j.kernel.impl.api.TransactionToApply;
 import org.neo4j.kernel.impl.api.index.IndexStoreView;
@@ -207,8 +206,7 @@ private LabelScanStore startLabelScanStore( Config config, Dependencies dependen
         KernelExtensions extensions = life.add( new KernelExtensions(
                 kernelContext, (Iterable) load( KernelExtensionFactory.class ), dependencies, ignore() ) );
         life.start();
-        LabelScanStore labelScanStore = extensions.resolveDependency( LabelScanStoreProvider.class,
-                new NamedLabelScanStoreSelectionStrategy( config ) ).getLabelScanStore();
+        LabelScanStore labelScanStore = extensions.resolveDependency( LabelScanStoreProvider.class ).getLabelScanStore();
         life.shutdown();
 
         // Start the selected LSS

community/kernel/src/main/java/org/neo4j/kernel/NeoStoreDataSource.java

@@ -45,9 +45,7 @@
 import org.neo4j.kernel.api.labelscan.LabelScanStore;
 import org.neo4j.kernel.api.legacyindex.AutoIndexing;
 import org.neo4j.kernel.configuration.Config;
-import org.neo4j.kernel.extension.dependency.DeleteStoresFromOtherLabelScanStoreProviders;
 import org.neo4j.kernel.extension.dependency.HighestSelectionStrategy;
-import org.neo4j.kernel.extension.dependency.NamedLabelScanStoreSelectionStrategy;
 import org.neo4j.kernel.guard.Guard;
 import org.neo4j.kernel.impl.api.CommitProcessFactory;
 import org.neo4j.kernel.impl.api.ConstraintEnforcingEntityOperations;
@@ -410,10 +408,7 @@ public void start() throws IOException
                 HighestSelectionStrategy.getInstance() );
         dependencies.satisfyDependency( schemaIndexProvider );
 
-        labelScanStoreProvider = dependencyResolver.resolveDependency( LabelScanStoreProvider.class,
-                new NamedLabelScanStoreSelectionStrategy( config ) );
-        dependencyResolver.resolveDependency( LabelScanStoreProvider.class,
-                new DeleteStoresFromOtherLabelScanStoreProviders( labelScanStoreProvider ) );
+        labelScanStoreProvider = dependencyResolver.resolveDependency( LabelScanStoreProvider.class );
 
         IndexConfigStore indexConfigStore = new IndexConfigStore( storeDir, fs );
         dependencies.satisfyDependency( lockService );

community/kernel/src/main/java/org/neo4j/unsafe/batchinsert/internal/BatchInserterImpl.java

@@ -79,7 +79,6 @@
 import org.neo4j.kernel.extension.KernelExtensions;
 import org.neo4j.kernel.extension.UnsatisfiedDependencyStrategies;
 import org.neo4j.kernel.extension.dependency.HighestSelectionStrategy;
-import org.neo4j.kernel.extension.dependency.NamedLabelScanStoreSelectionStrategy;
 import org.neo4j.kernel.impl.api.index.NodeUpdates;
 import org.neo4j.kernel.impl.api.index.SchemaIndexProviderMap;
 import org.neo4j.kernel.impl.api.index.StoreScan;
@@ -298,8 +297,7 @@ public BatchInserterImpl( final File storeDir, final FileSystemAbstraction fileS
         SchemaIndexProvider provider = extensions.resolveDependency( SchemaIndexProvider.class,
                 HighestSelectionStrategy.getInstance() );
         schemaIndexProviders = new DefaultSchemaIndexProviderMap( provider );
-        labelScanStore = life.add( extensions.resolveDependency( LabelScanStoreProvider.class,
-                new NamedLabelScanStoreSelectionStrategy( config ) ).getLabelScanStore() );
+        labelScanStore = life.add( extensions.resolveDependency( LabelScanStoreProvider.class ).getLabelScanStore() );
         actions = new BatchSchemaActions();
 
         // Record access

community/kernel/src/main/java/org/neo4j/unsafe/impl/batchimport/store/BatchingNeoStores.java

@@ -37,7 +37,6 @@
 import org.neo4j.kernel.extension.KernelExtensionFactory;
 import org.neo4j.kernel.extension.KernelExtensions;
 import org.neo4j.kernel.extension.UnsatisfiedDependencyStrategies;
-import org.neo4j.kernel.extension.dependency.NamedLabelScanStoreSelectionStrategy;
 import org.neo4j.kernel.impl.api.index.IndexStoreView;
 import org.neo4j.kernel.impl.api.scan.LabelScanStoreProvider;
 import org.neo4j.kernel.impl.factory.DatabaseInfo;
@@ -175,8 +174,7 @@ private BatchingNeoStores( FileSystemAbstraction fileSystem, PageCache pageCache
                 kernelContext, (Iterable) Service.load( KernelExtensionFactory.class ),
                 dependencies, UnsatisfiedDependencyStrategies.ignore() ) );
         life.start();
-        labelScanStore = life.add( extensions.resolveDependency( LabelScanStoreProvider.class,
-                new NamedLabelScanStoreSelectionStrategy( neo4jConfig ) ).getLabelScanStore() );
+        labelScanStore = life.add( extensions.resolveDependency( LabelScanStoreProvider.class ).getLabelScanStore() );
     }
 
     public static BatchingNeoStores batchingNeoStores( FileSystemAbstraction fileSystem, File storeDir,

tools/src/main/java/org/neo4j/tools/migration/StoreMigration.java

@@ -37,7 +37,6 @@
 import org.neo4j.kernel.configuration.Settings;
 import org.neo4j.kernel.extension.KernelExtensions;
 import org.neo4j.kernel.extension.dependency.HighestSelectionStrategy;
-import org.neo4j.kernel.extension.dependency.NamedLabelScanStoreSelectionStrategy;
 import org.neo4j.kernel.impl.api.scan.LabelScanStoreProvider;
 import org.neo4j.kernel.impl.factory.DatabaseInfo;
 import org.neo4j.kernel.impl.logging.StoreLogService;
@@ -126,8 +125,7 @@ public void run( final FileSystemAbstraction fs, final File storeDirectory, Conf
 
             SchemaIndexProvider schemaIndexProvider = kernelExtensions.resolveDependency( SchemaIndexProvider.class,
                     HighestSelectionStrategy.getInstance() );
-            LabelScanStoreProvider labelScanStoreProvider = kernelExtensions.resolveDependency(
-                    LabelScanStoreProvider.class, new NamedLabelScanStoreSelectionStrategy( config ) );
+            LabelScanStoreProvider labelScanStoreProvider = kernelExtensions.resolveDependency( LabelScanStoreProvider.class );
             long startTime = System.currentTimeMillis();
             DatabaseMigrator migrator = new DatabaseMigrator( progressMonitor, fs, config, logService,
                     schemaIndexProvider, labelScanStoreProvider, legacyIndexProvider.getIndexProviders(),