raft-messages.log can now be enabled/disabled via config.

It is disabled by default as per production norms.
neo4j · Feb 25, 2016 · cafb75f · cafb75f
1 parent ee7cf72
commit cafb75f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/enterprise/core-edge/src/main/java/org/neo4j/coreedge/server/CoreEdgeClusterSettings.java b/enterprise/core-edge/src/main/java/org/neo4j/coreedge/server/CoreEdgeClusterSettings.java
@@ -186,4 +186,8 @@ public String toString()
     @Description("RAFT meta data cache size (in unit of entries)")
     public static final Setting<Integer> raft_log_meta_data_cache_size =
             setting( "core_edge.raft_log_meta_data_cache_size", INTEGER, "100000" );
+
+    @Description("Enable or disable the dump of all network messages pertaining to the RAFT protocol")
+    public static final Setting<Boolean> raft_messages_log_enable =
+            setting( "core_edge.raft_messages_log_enable", BOOLEAN, "false");
 }
diff --git a/...e/core-edge/src/main/java/org/neo4j/coreedge/server/core/EnterpriseCoreEditionModule.java b/...e/core-edge/src/main/java/org/neo4j/coreedge/server/core/EnterpriseCoreEditionModule.java
@@ -29,7 +29,6 @@
 import java.util.concurrent.TimeUnit;
 import java.util.function.Supplier;
 
-import org.neo4j.cluster.ExecutorLifecycleAdapter;
 import org.neo4j.coreedge.catchup.CatchupServer;
 import org.neo4j.coreedge.catchup.CheckpointerSupplier;
 import org.neo4j.coreedge.catchup.DataSourceSupplier;
@@ -98,11 +97,13 @@
 import org.neo4j.coreedge.server.core.locks.ReplicatedLockTokenStateMachine;
 import org.neo4j.coreedge.server.logging.BetterMessageLogger;
 import org.neo4j.coreedge.server.logging.MessageLogger;
+import org.neo4j.coreedge.server.logging.NullMessageLogger;
 import org.neo4j.graphdb.DependencyResolver;
 import org.neo4j.graphdb.factory.GraphDatabaseSettings;
 import org.neo4j.io.fs.FileSystemAbstraction;
 import org.neo4j.io.pagecache.PageCache;
 import org.neo4j.kernel.DatabaseAvailability;
+import org.neo4j.kernel.impl.transaction.log.PhysicalLogFile;
 import org.neo4j.kernel.internal.GraphDatabaseAPI;
 import org.neo4j.kernel.internal.KernelData;
 import org.neo4j.kernel.NeoStoreDataSource;
@@ -125,7 +126,6 @@
 import org.neo4j.kernel.impl.store.stats.IdBasedStoreEntityCounters;
 import org.neo4j.kernel.impl.transaction.TransactionHeaderInformationFactory;
 import org.neo4j.kernel.impl.transaction.log.LogicalTransactionStore;
-import org.neo4j.kernel.impl.transaction.log.PhysicalLogFile;
 import org.neo4j.kernel.impl.transaction.log.TransactionIdStore;
 import org.neo4j.kernel.impl.util.Dependencies;
 import org.neo4j.kernel.internal.DatabaseHealth;
@@ -204,8 +204,15 @@ public EnterpriseCoreEditionModule( final PlatformModule platformModule,
                 config.get( CoreEdgeClusterSettings.transaction_advertised_address ),
                 config.get( CoreEdgeClusterSettings.raft_advertised_address ) );
 
-        final MessageLogger<AdvertisedSocketAddress> messageLogger =
-                new BetterMessageLogger<>( myself.getRaftAddress(), raftMessagesLog( storeDir ) );
+        final MessageLogger<AdvertisedSocketAddress> messageLogger;
+        if ( config.get( CoreEdgeClusterSettings.raft_messages_log_enable ) )
+        {
+            messageLogger = new BetterMessageLogger<>( myself.getRaftAddress(), raftMessagesLog( storeDir ) );
+        }
+        else
+        {
+            messageLogger = new NullMessageLogger<>();
+        }
 
         LoggingOutbound<AdvertisedSocketAddress> loggingOutbound = new LoggingOutbound<>(
                 senderService, myself.getRaftAddress(), messageLogger );