Support traversing groups through buffering

neo4j · Nov 9, 2017 · ce9c593 · ce9c593
1 parent e84fcb1
commit ce9c593
Show file tree

Hide file tree

Showing 2 changed files with 81 additions and 4 deletions.
diff --git a/community/kernel/src/main/java/org/neo4j/kernel/impl/newapi/RelationshipGroupCursor.java b/community/kernel/src/main/java/org/neo4j/kernel/impl/newapi/RelationshipGroupCursor.java
@@ -21,6 +21,7 @@
 
 import org.neo4j.collection.primitive.Primitive;
 import org.neo4j.collection.primitive.PrimitiveIntObjectMap;
+import org.neo4j.kernel.impl.newapi.RelationshipTraversalCursor.Record;
 import org.neo4j.kernel.impl.store.record.RelationshipGroupRecord;
 import org.neo4j.kernel.impl.store.record.RelationshipRecord;
 
@@ -256,9 +257,9 @@ static class Group
     {
         final int label;
         final Group next;
-        RelationshipTraversalCursor.Record outgoing;
-        RelationshipTraversalCursor.Record incoming;
-        RelationshipTraversalCursor.Record loops;
+        Record outgoing;
+        Record incoming;
+        Record loops;
         private long firstOut = NO_ID;
         private long firstIn = NO_ID;
         private long firstLoop = NO_ID;

diff --git a/community/kernel/src/main/java/org/neo4j/kernel/impl/newapi/RelationshipTraversalCursor.java b/community/kernel/src/main/java/org/neo4j/kernel/impl/newapi/RelationshipTraversalCursor.java
@@ -27,24 +27,36 @@ class RelationshipTraversalCursor extends RelationshipCursor
 {
     private long originNodeReference;
     private long next;
+    private Record buffer;
 
     RelationshipTraversalCursor( Read read )
     {
         super( read );
     }
 
+    /*
+     * Cursor being called as a group, use the buffered records in Record
+     * instead.
+     */
     void buffered( long nodeReference, Record record )
     {
-        throw new UnsupportedOperationException( "not implemented" );
+        this.originNodeReference = nodeReference;
+        this.buffer = Record.initialize( record );
     }
 
+    /*
+     * Normal traversal.
+     */
     void chain( long nodeReference, long reference )
     {
         setId( NO_ID );
         originNodeReference = nodeReference;
         next = reference;
     }
 
+    /*
+     * Reference to a group record
+     */
     void groups( long nodeReference, long reference )
     {
         throw new UnsupportedOperationException( "not implemented" );
@@ -95,6 +107,27 @@ public long originNodeReference()
     @Override
     public boolean next()
     {
+        if ( hasBufferedData() )
+        {   //We have buffered data, iterate the chain of buffered records
+            buffer = buffer.next;
+            if ( !hasBufferedData() )
+            {
+                close();
+                return false;
+            }
+            else
+            {
+                // Copy buffer data to self
+                this.setId( buffer.id );
+                this.setType( buffer.type );
+                this.setNextProp( buffer.nextProp );
+                this.setFirstNode( buffer.firstNode );
+                this.setSecondNode( buffer.secondNode );
+                return true;
+            }
+        }
+
+
         if ( next == NO_ID )
         {
             close();
@@ -127,14 +160,57 @@ public boolean shouldRetry()
     public void close()
     {
         setId( next = NO_ID );
+        buffer = null;
+    }
+
+    private boolean hasBufferedData()
+    {
+        return buffer != null;
     }
 
+    /*
+     * Record is both a data holder for buffering data from a RelationshipRecord
+     * as well as a linked list over the records in the group.
+     */
     static class Record
     {
+        private static final RelationshipRecord DUMMY = null;
+        final long id;
+        final int type;
+        final long nextProp;
+        final long firstNode;
+        final long secondNode;
         final Record next;
 
+        /*
+         * Initialize the chain of records
+         */
+        static Record initialize(Record first)
+        {
+            return new Record( DUMMY, first );
+        }
+
+        /*
+         * Initialize the record chain or push a new record as the new head of the record chain
+         */
         Record( RelationshipRecord record, Record next )
         {
+            if ( record != null )
+            {
+                id = record.getId();
+                type = record.getType();
+                nextProp = record.getNextProp();
+                firstNode = record.getFirstNode();
+                secondNode = record.getSecondNode();
+            }
+            else
+            {
+                id = NO_ID;
+                type = NO_ID;
+                nextProp = NO_ID;
+                firstNode = NO_ID;
+                secondNode = NO_ID;
+            }
             this.next = next;
         }
     }