Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell: move history file to user directory #1395

Closed
jotomo opened this issue Oct 31, 2013 · 2 comments
Closed

Shell: move history file to user directory #1395

jotomo opened this issue Oct 31, 2013 · 2 comments
Labels

Comments

@jotomo
Copy link
Contributor

jotomo commented Oct 31, 2013

The shell writes the history file to $PWD/.shell_history. This creates this file in all sorts of places and can be somewhat annoying as well as breaking the shell when the user has no write permission in the current directorp (as experienced here https://groups.google.com/forum/#!topic/neo4j/4RVKnET9nlc).

Would a patch to change this behaviour to write to ~/.neo4j_shell_history instead be welcome? There might be an issue with multiple shells open at the same time, writing into the same history file, but that problem also exists when multiple shells are started from the same directory.

@jakewins
Copy link
Contributor

jakewins commented Nov 1, 2013

@tinwelint I'm not aware of the shell history file, could you give input on this?

The only thing I can think is that maybe it's confusing if different shells share history, eg. if you run multiple dbs. But actually, I could find that pretty useful. It's like how zsh has shared history across shells, and that ends up being very useful.

@jotomo
Copy link
Contributor Author

jotomo commented Nov 29, 2013

@tinwelint @jakewins While this isn't a bug, it appears to be rather annoying on Windows too, where the shell launches from something like C:\Program Files\Neo4j Community, which is r/o for a non-priviliged user, causing the entered commands to become invisible without any clue as to the cause, as describe by Mark Needham here.
So, I'm thinking maybe this can be adressed pre-GA, to avoid more people running into this?

tinwelint added a commit that referenced this issue Dec 19, 2013
Shell: save history in home dir. Closes #1395.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants