Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3.0-RC1][Rest API] BC when listing labels - /labels endpoint #5665

Closed
ikwattro opened this issue Oct 18, 2015 · 3 comments
Closed

[2.3.0-RC1][Rest API] BC when listing labels - /labels endpoint #5665

ikwattro opened this issue Oct 18, 2015 · 3 comments
Labels

Comments

@ikwattro
Copy link
Contributor

I know it's sunday :)

I guess it is related to the fact that unused labels are removed.

There is a slight BC when listing labels with the /db/data/labels endpoint :

  1. Fresh new install of neo
  2. Create a new index : CREATE INDEX ON :TestNode(id);
  3. Try to list labels : GET http://localhost:7474/db/data/labels

Returns an empty body, in 2.2.6 it is returning the TestNode label.

This has as side effect that you can not list all indexes of the database from a driver without passing by the /manage/server/console/ endpoint, which is anyway inadvertently disabled in RC1.

I personally don't think that not listing the label is an issue but rather there is a BC for the labels endpoint which might affect other users or drivers.

Cheers

Chris

@oskarhane
Copy link
Member

Hi @ikwattro, thanks for the report / heads up on this.
You can still fetch all labels like before, by passing the query param in_use=0, like :GET /db/data/labels?in_use=0.

And regarding the disabled /manage/server/console/, that is fixed and will be in the next release.

Cheers

@ikwattro
Copy link
Contributor Author

Thanks Oscar,

I wasn't aware of this param. Thanks.

Cheers

On 19 October 2015 at 08:54, Oskar Hane notifications@github.com wrote:

Hi @ikwattro https://github.com/ikwattro, thanks for the report / heads
up on this.

You can still fetch all labels like before, by passing the query param
in_use=0, like :GET /db/data/labels?in_use=0.

And regarding the disabled /manage/server/console/, that is fixed and
will be in the next release.

Cheers


Reply to this email directly or view it on GitHub
#5665 (comment).

Christophe Willemsen | Graph Aware Limited

Phone: +44 (0) 333 444 7274 | Mobile: +32 (0) 489 687 208
christophe@graphaware.com | @graph_aware | www.graphaware.com

@ikwattro
Copy link
Contributor Author

@oskarhane Maybe I can close this issue and make a PR for the documentation instead ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants