PruningVarExpand should handle incoming null nodes #10367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fickludd
suggested changes
Nov 1, 2017
| row = row, | ||
| expandMap = Primitive.longObjectMap[FullExpandDepths]()) | ||
| nextState.next() | ||
| case Some(x: Value) if x.asObject() == null => |
There was a problem hiding this comment.
This is correct but slightly strange. I would prefer
case Some(x: Value) if x == NO_VALUE =>
or even
case Some(NO_VALUE) =>
if that's allowed
There was a problem hiding this comment.
We tried to write i prettier but we didn't managed, must ave been trying to use the wrong NO_VALUE or something. However, fixed it now in a new commit.
fickludd
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fixes #9492, so that PruningVarExpand after optional match will handle incoming null nodes