improvements for neo4j-harness #4330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* expose GraphDatabaseService in ServerControls and Neo4jRule -> enables assertions based on GDB * enable GDB based fixtures by using Function<GraphDatbaseService,Void>
* InProcessServerBuilder and Neo4jRule use a exisiting graph.db
|
Big 👍 |
TestServerBuilder has a copyFrom(File) method that populates the server's graph db directory with the contents of an existing store.
|
updated the PR based on a discussion with @cleishm. Instead of directly using the source store, it is copied over using `TestServerBuilder.copyFrom(File)? |
|
Looks good Stefan! |
|
Would you add a small note in the changelog of this module to the PR? |
|
@sarmbruster looks good! I've rebased this onto latest 2.3 and squashed it into one commit, will merge once this PR is green: #4516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 small improvements for neo4j-harness: