Fix Cluster Uri regression again #5932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously fixed in PR #5869, but that change broke tyre-kicking somehow. This is the minimum fix, which simply reverts part of 5f7bf49 This change has been verified to not break tyre-kicking, as well as fixing the root cause (we shouldn't do a reverseDNS lookup of the hostname of the local machine).
|
Looks good. Verified again with tyre-kicking and it no longer fails. |
maxsumrall
pushed a commit
that referenced
this pull request
Nov 24, 2015
Fix Cluster Uri regression again tyre-kicking problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously fixed in PR #5869, but that change broke
tyre-kicking somehow.
This is the minimum fix, which simply reverts part of
5f7bf49
This change has been verified to not break tyre-kicking, as well
as fixing the root cause (we shouldn't do a reverseDNS lookup of
the hostname of the local machine).
Fixes #5804