Fixed issue with last committed tx id in query planning #5935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoStore benefits from such check because it is often used as the source of different transaction related counters. So with the assertion in place NeoStore is no longer able to expose those counters after being closed.
|
@maxsumrall looks fine, small details to be fixed |
maxsumrall
force-pushed
the
2.2-slave-replanning
branch
from
65faa36
to
dcef31c
Compare
This issue could result in slaves never re-planing queries after a mode switch or even directly after the startup. It occurred because function that resolved last committed transaction id held a reference to a stale TransactionIdStore. TransactionIdStore is re-initialized after the NeoStoreDataSource restart which happens after mode switch in HA. Introduced LastCommittedTxIdProvider that is able to take last committed transaction id from the given GraphDatabaseService.
maxsumrall
force-pushed
the
2.2-slave-replanning
branch
from
dcef31c
to
7398b85
Compare
davidegrohmann
added a commit
that referenced
this pull request
Nov 24, 2015
Fixed issue with last committed tx id in query planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue could result in slaves never re-planing queries after a mode switch or even directly after the startup. It occurred because function that resolved last committed transaction id held a reference to a stale TransactionIdStore.
TransactionIdStoreis re-initialized after theNeoStoreDataSourcerestart which happens after mode switch in HA.Introduced
LastCommittedTxIdProviderthat is able to take last committed transaction id from the given GraphDatabaseService.