switch for running queries eagerly #5968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pontusmelke
force-pushed
the
3.0-eager-switch
branch
5 times, most recently
from
2612b16
to
0ff01f1
Compare
|
I don't like |
|
Internally you are using updateStrategy, I think |
|
|
||
| val planWithEffect = | ||
| if (conflicts(partPlan, in)) | ||
| if (alwaysEager ||conflicts(partPlan, in)) |
We no longer support options like `PLANNER RULE` we should only support `CYPHER planner=rule`
`EagerApplyPipe` was doing the wrong thing. Removed instead of fixed since it does not provide any benefit.
pontusmelke
force-pushed
the
3.0-eager-switch
branch
from
512d143
to
9a8d278
Compare
|
@craigtaverner changed to |
systay
added a commit
that referenced
this pull request
Dec 1, 2015
switch for running queries eagerly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLANNER COST MATCH...)CYPHER updateStrategy=eager...updateWithBothPlannersto use and compare with and without eagerness.EagerApply