Unify BOLT into a single port #6020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
force-pushed
the
3.0-one-port-bolt
branch
6 times, most recently
from
a7cdbb2
to
7017c6f
Compare
zhenlineo
force-pushed
the
3.0-one-port-bolt
branch
from
7017c6f
to
8170856
Compare
| switch ( connector.get( Settings.tls_level ) ) | ||
| { | ||
| case REQUIRED: | ||
| requireEncryption = true; |
There was a problem hiding this comment.
Is the fall through intended?, otherwise add break
Reading through the code I figure it must be intentional, can we at least have some comment clarifying that it is by design we fall through here.
Move TCP, secure TCP, websocket, secure websocket into one single port 7687 This allows an informative message to be returned, instructing the user that a encrypted connection is required or forbidden.
zhenlineo
force-pushed
the
3.0-one-port-bolt
branch
from
8170856
to
6a8639a
Compare
pontusmelke
added a commit
that referenced
this pull request
Dec 16, 2015
Unify BOLT into a single port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move TCP, secure TCP, websocket, secure websocket into one single port 7687
This allows an informative message to be returned,
instructing the user that a encrypted connection is required or forbidden.