Make SlaveLockClient cope better with ComExceptions #6102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was an indirect way of reading the lock_read_timeout HA setting lazily or something. Who knows why it was introduced in the first place.
These methods were never used anywhere, and didn't quite make sense anyway. We already use the `releaseAll` method anywhere it matters.
…communication failures And also add a bunch of tests for these failure modes. The DistributedLockFailureException extends the user-facing TransientTransactionFailureExcpetion, so user-code can actually catch and deal with it. It is also more descriptive, because a ComException doesn't really say much that is actually useful and actionable to the user. Especially since they have no idea that it can happen in the first place, and - it being a RuntimeException - pop up pretty much anywhere.
davidegrohmann
added a commit
that referenced
this pull request
Dec 18, 2015
Make SlaveLockClient cope better with ComExceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be aware that packages and classes have moved around a lot in newer branches, so great care should be taking when merging this forward.