Fix Integer overflow for large number of dense nodes #6253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-author: tinwelint Fakes high ids in order to test the behavior on machines without insane amounts of RAM. See previous commit for fix for original bug where a AtomicInteger would overflow.
tinwelint
added a commit
that referenced
this pull request
Jan 26, 2016
Fix Integer overflow for large number of dense nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered during large LDBC import.
Do not merge until a new LDBC run has confirmed the fix.EDIT:
Good change regardless if it fixes LDBC, so I think we can merge it right away.