Mark deleted entities as deleted in the string serialization #6354
Conversation
Mats-SX
force-pushed
the
3.0-deleted-entities-serialization2
branch
2 times, most recently
from
736598f
to
e0bb8ea
Compare
Mats-SX
force-pushed
the
3.0-deleted-entities-serialization2
branch
3 times, most recently
from
09f1e72
to
27f41a7
Compare
|
lgtm from a consumers pov |
| @@ -82,14 +83,30 @@ | |||
| import static org.neo4j.test.mocking.GraphMock.relationship; | |||
| import static org.neo4j.test.mocking.Properties.properties; | |||
|
|
|||
| public class ExecutionResultSerializerTest | |||
| public class ExecutionResultSerializerTest extends TxStateCheckerTestSupport | |||
There was a problem hiding this comment.
Do we have any tests covering the nested cases?
MATCH (n) DELETE (n) RETURN [n, {someKey: n}]
Also, I'm still unclear on the use case here - what is the remote client supposed to do with the 'isDeleted' flag? Similar for the id that gets returned, the use case seems unclear. Since 99% applications in the wild use labels/properties for identity, what are they supposed to do with that lone id?
There was a problem hiding this comment.
The id gets returned I guess because it is the only thing that we can return. The deleted flag could be checked in order for the client to not get exceptions when trying to lookup properties of the deleted entities. Also, it differentiates the returned entities from non-deleted, property-less dittos. Returning the node without properties (if it had any) would be bad. Returning with properties is not possible.
|
@jakewins Added a smoke test for nesting deleted entities. Good catch. |
| value.asInstanceOf[Relationship].getType.name() | ||
|
|
||
| def compute(value: Any, m: ExecutionContext)(implicit state: QueryState): String = | ||
| value match { |
There was a problem hiding this comment.
Can't we use CastSupport.castOrFail here?
When returning labels, properties, or relationship types of deleted entities, we now throw exceptions. Cleaned up the `type()` function.
Nodes and relationships that are deleted and returned in the same query will not get their properties serialized, but instead will get a boolean field 'deleted' set to true. This commit solves both the 'graph' and the 'row' serializations.
The serialization format `rest` will now be able to correctly return deleted nodes and relationships.
The row format now will print a sibling 'meta' array, containing node and relationship ids, the respective type, and the 'deleted' marker field.
Mats-SX
force-pushed
the
3.0-deleted-entities-serialization2
branch
from
5dfb605
to
ac23b4d
Compare
|
@systay Dealt with your comments, thank you. |
…ion2 Mark deleted entities as deleted in the string serialization
Builds on #6352.
Supersedes #6329.