Fix incorrect counts for relationships with direction BOTH #6881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -260,45 +260,6 @@ class MatchAggregationsBackedByCountStoreAcceptanceTest extends ExecutionEngineF | |||
| }) | |||
| } | |||
|
|
|||
| test("counts relationships with type, any direction and labeled source node without using count store") { | |||
There was a problem hiding this comment.
These tests should remain, but change the test to assert that the count store is no longer used.
The previous counts store based implementation was simply summing the count for outgoing relationships with the count for incoming relationships. This is not correct since we count twice all the relationships that same node as source and target. This commit will remove the counts store shortcuts for such cases. We could reintroduce the counts store based implementation when we'll start counting loop relationships on nodes as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous counts store based implementation was simply summing the
count for outgoing relationships with the count for incoming
relationships. This is not correct since we count twice all the
relationships that same node as source and target. This commit will
remove the counts store shortcuts for such cases. We could
reintroduce the counts store based implementation when we'll start
counting loop relationships on nodes as well.