ImportTool now prints neo4j version #7057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -403,6 +403,7 @@ public static void main( String[] incomingArguments, boolean defaultSettingsSuit | |||
| private static void printOverview( File storeDir, Collection<Option<File[]>> nodesFiles, | |||
| Collection<Option<File[]>> relationshipsFiles ) | |||
| { | |||
| System.out.println( "Neo4j version: " + Version.getKernel().getVersion() ); | |||
There was a problem hiding this comment.
Is there a Version.getKernel().getReleaseVersion() in 2.2? If there is it might be better to use it because it gives the version without including the git hash. If there isn't, then I suggest looking for it when forward merging and using it as soon as it appears. Don't think there is any need to print out the git hash in this output.
See Mattias change at https://github.com/neo4j/neo4j/blame/2.3/community/import-tool/src/main/java/org/neo4j/tooling/ImportTool.java#L522 for something similar (but there it was included in a URI, which meant the git hash actually broke things).
When importing a database, the release version number of neo4j is printed. This will help when user copy-paste output for support cases.
burqen
force-pushed
the
2.2-import-tool-print-version
branch
from
3ccd9b3
to
1b638dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a database, the version number of neo4j (including git branch) is printed.
This will help when user copy-paste output for support cases.
changelog: [import tool] Added print of Neo4j version