Remove compiled runtime from 2.3 #7107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "planner" : "cost", | |||
| "runtime" : "compiled" | |||
| "runtime" : "interpreted" | |||
There was a problem hiding this comment.
This file may be removed completely, since you're removing its only usage above.
|
@pontusmelke Looks good. Just one minor comment. If you don't find time to update that, or disagree with the comment, I'll merge in a day or two. |
|
Yeah I know, it is a little weird to still have it configurable, but I am a little hesitant to remove the configuration option since it may have been set somewhere (and it is more work to remove it :) ) |
|
I was referring to the first comment (changing an obsoleted file). The second comment was a feeble attempt at a joke. I 100% agree with not removing the config option. |
In 2.3 the compiled runtime has some unwanted dependencies that makes refactoring hard, so let's just remove it.
pontusmelke
force-pushed
the
2.3-remove-compiled
branch
from
36ed284
to
e26674d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.3 the compiled runtime has some unwanted dependencies that makes refactoring hard,
so let's just remove it.
NOTE: Please do a null forward merge for this PR and let the compiled runtime remain in 3.0.