Safe freeing of ids for HA slaves #7511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved safeZone handling logic from BatchingResponseHandler to new TransactionQueue.Applier to have a cleaner separation of responsibility. Now TransactionQueue drive batching and transaction application instead of BatchingResponseHandler.
| this( "" ); | ||
| super( "The transaction has been terminated.Simply retry your operation in a new transaction, " + | ||
| "and you should see a successful result." + status.code().description() + " " + additionalInfo ); | ||
| this.status = status; |
There was a problem hiding this comment.
You are missing a space in the message, before Simply. Also, I don't think the word "simply" adds very much.
There was a problem hiding this comment.
There's also no space between the message and the status code description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward merge of #7477
MASTER
Master now buffer ids for a specified time, called the safe zone. Within this safe zone window
records are guaranteed not to be reused.
SLAVE
UpdatePuller makes sure no transactions break the safe zone boundary
by killing transactions that fall outside during pull update.
The transactions store the latest_applied_transaction_commit_time when
they start and
TransactionCommitingResonseUnpackerkills the transactionsas new transactions (pulled from master) get applied by comparing
the stored commit_time with the new latest_applied_transaction_commit_time
after applying the batch.
If the batch itself spans over a greater time than what fits inside the safe zone,
no more transacions can be started on slave until the entire batch is applied.
Safe zone is configurable through a setting
SECONDARY CHANGES
Added knowledge about last tx commit timestamp to MetaDataStore and StoreMigrator