Added tests for node id reuse #7600
Conversation
To make sure it is possible to specify `NODE` as well as `RELATIONSHIP` in `dbms.ids.reuse.types.override` setting.
| @@ -32,7 +32,7 @@ | |||
| public class EnterpriseEditionSettings | |||
| { | |||
| @Description( "Specified names of id types (comma separated) that should be reused. " + | |||
| "Currently only 'RELATIONSHIP' type is supported. " ) | |||
There was a problem hiding this comment.
Where is the actual list of supported types enforced?
There was a problem hiding this comment.
It is not enforced. I'll add this.
There was a problem hiding this comment.
Will this PR then enable NODE to be used? I'd expect not since it's merely adding tests.
There was a problem hiding this comment.
Right, it will not enable node id reuse. It might not be entirely safe to enable node/relationship id reuse in 2.3. We should probably do it for 3.1.
There was a problem hiding this comment.
@tinwelint added restriction on values in the list
There was a problem hiding this comment.
Oh, so there was previously nothing preventing config from specifying NODE or any other id type?
There was a problem hiding this comment.
Yes right, sorry, missed your message somehow.
Only node and relationship id reuse is supported. This commit makes the corresponding setting accept list of only those tow values.
To make sure it is possible to specify
NODEas well asRELATIONSHIPindbms.ids.reuse.types.overridesetting.changelog: [enterprise] Made possible to allow node id reuse using 'dbms.ids.reuse.types.override' setting.