Single active update puller #7909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After introduction of detached state components lifecycle was change in a way that now it's possible to start new set of components while you still have old one active. For case of update puller it mean that for some time we will have 2 update pullers active and they will try to apply transactions concurrently. That is incorrect and causing errors during transactions apply phase. This commit introduce new phase in component switch lifecycle, just after old component shutdown. And we will use this phase to start new update puller @pair-with @lutovich
|
@digitalstain can you please take a look, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introduction of detached state components lifecycle was change in a way that now it's possible to start new set of components while you still have old one active.
For case of update puller it mean that for some time we will have 2 update pullers active and they will try to apply transactions concurrently.
That is incorrect and causing errors during transactions apply phase.
This commit introduce new phase in component switch lifecycle, just after old component shutdown. And we will use this phase to start new update puller
@pair-with @lutovich
changelog: Update ha component lifecycle to make sure we have only one active update puller on slaves