Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated SSL certificate files should only be readable by owner. #8510

Merged
merged 3 commits into from
Dec 19, 2016
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -193,5 +193,9 @@ private void writePem( String type, byte[] encodedContent, File path ) throws IO
writer.writeObject( new PemObject( type, encodedContent ) );
writer.flush();
}
path.setReadable( false, false );
path.setWritable( false, false );
path.setReadable( true );
path.setWritable( true );
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
/*
* Copyright (c) 2002-2016 "Neo Technology,"
* Network Engine for Objects in Lund AB [http://neotechnology.com]
*
* This file is part of Neo4j.
*
* Neo4j is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package org.neo4j.server.security.ssl;

import org.apache.commons.lang.SystemUtils;
import org.junit.Rule;
import org.junit.Test;

import java.io.File;
import java.nio.file.Files;
import java.nio.file.attribute.PosixFileAttributeView;
import java.nio.file.attribute.PosixFileAttributes;
import java.nio.file.attribute.PosixFilePermission;

import org.neo4j.test.TargetDirectory;

import static org.junit.Assert.*;
import static org.junit.Assume.assumeTrue;
import static org.neo4j.test.TargetDirectory.testDirForTest;

public class CertificatesIT
{
@Rule
public TargetDirectory.TestDirectory testDirectory = TargetDirectory.testDirForTest( getClass() );

@Test
public void createSelfSignedCertificate() throws Exception
{
assumeTrue( !SystemUtils.IS_OS_WINDOWS );

Certificates certificates = new Certificates();
certificates
.createSelfSignedCertificate( testDirectory.file( "certificate" ), testDirectory.file( "privateKey" ),
"localhost" );

PosixFileAttributes certificateAttributes =
Files.getFileAttributeView( testDirectory.file( "certificate" ).toPath(), PosixFileAttributeView.class )
.readAttributes();

assertTrue( certificateAttributes.permissions().contains( PosixFilePermission.OWNER_READ ) );
assertTrue( certificateAttributes.permissions().contains( PosixFilePermission.OWNER_WRITE ) );
assertFalse( certificateAttributes.permissions().contains( PosixFilePermission.OWNER_EXECUTE ) );

assertFalse( certificateAttributes.permissions().contains( PosixFilePermission.GROUP_READ ) );
assertFalse( certificateAttributes.permissions().contains( PosixFilePermission.GROUP_WRITE ) );
assertFalse( certificateAttributes.permissions().contains( PosixFilePermission.GROUP_EXECUTE ) );

assertFalse( certificateAttributes.permissions().contains( PosixFilePermission.OTHERS_READ ) );
assertFalse( certificateAttributes.permissions().contains( PosixFilePermission.OTHERS_WRITE ) );
assertFalse( certificateAttributes.permissions().contains( PosixFilePermission.OTHERS_EXECUTE ) );
}
}