Fix eagerness for labels() function #8575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should also work for horizons of query graph tails
Fixes an eagerness bug in both rule and cost planner for relationship property reads in horizon
We need to be eager when the use of labels() function in a query horizon conflicts with a label write, which requires new conflict checks. - For the rule planner a new read effect is introduced - For read-write conflicts in the cost planner, a new location to plan eagerness is introduced, with a dedicated check and pass, after planning the event horizon. - For write-read conflicts in the cost planner, the check is added to the existing passes.
Mats-SX
approved these changes
Jan 9, 2017
| if (tail.queryGraph.writeOnly) false | ||
| else | ||
| // NOTE: Here we do not check writeOnlyHeadOverlapsHorizon, because we do not know of any case where a | ||
| // write-only head could cause problems with reads in future horizons |
There was a problem hiding this comment.
That's a useful observation. I don't know any way for a write-only head to increase cardinality above one, which makes eagerness analysis trivial.
There was a problem hiding this comment.
Right, that explanation is more on point
| } || { | ||
| (labelsToSet.nonEmpty || removeLabelPatterns.nonEmpty) && | ||
| horizon.dependingExpressions.exists { | ||
| case f: FunctionInvocation if f.function.get == Labels => true |
There was a problem hiding this comment.
I'm wondering whether get here could ever throw exception?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be eager when the use of labels() function in a query horizon
conflicts with a label write, which requires new conflict checks.
is introduced, with a dedicated check and pass, after planning the event horizon.
existing passes.
Also fixes related eagerness bugs for property reads and extends testing.