Attempt fix for ClusterManager#startCluster() race #8760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A race where the normal methods like allSeesAllAsAvailable() would sometimes return true if there were no db started yet and therefore return prematurely. The test would then continue and request a db with a certain role, wouldn't find it and would fail because of it. This issue wasn't observed locally when coming up with the fix, but based on the logs on existing failing builds it looked like this could be the cause.
digitalstain
approved these changes
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A race where the normal methods like allSeesAllAsAvailable()
would sometimes return true if there were no db started yet and therefore
return prematurely. The test would then continue and request a db
with a certain role, wouldn't find it and would fail because of it.
This issue wasn't observed locally when coming up with the fix, but based
on the logs on existing failing builds it looked like this could be the cause.