Improve legacy index restoreSortFields speed. #8887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently introduced restoreSortFields have significant performance impact in case if index contains bunch of fields. This pr fix issue by avoiding multiple iterations over all document fields.
|
Fixes #8840 |
tinwelint
reviewed
Feb 28, 2017
| public TargetDirectory.TestDirectory directory = TargetDirectory.testDirForTest( getClass() ); | ||
|
|
||
| @Test( timeout = TEST_TIMEOUT ) | ||
| public void legacyIndexPopulationWithBunchOfFields() throws Exception |
There was a problem hiding this comment.
Is this the performance test that guided the changes? It has unclear goals/assertions IMHO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently introduced restoreSortFields have significant performance impact in case if
index contains bunch of fields. This pr fix issue by avoiding multiple iterations
over all document fields.
cl: Improve legacy index restoreSortFields speed. Fix for GH issue #8840