New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config support for legacy quote escaping in LOAD CSV #8903
Conversation
d815319
to
4b8ebf8
Compare
@@ -37,6 +37,7 @@ case class LogicalPlanningContext(planContext: PlanContext, | |||
useErrorsOverWarnings: Boolean = false, | |||
errorIfShortestPathFallbackUsedAtRuntime: Boolean = false, | |||
errorIfShortestPathHasCommonNodesAtRuntime: Boolean = true, | |||
legacyCsvQuoteEscaping: Boolean = true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of places where there's a default value specified here. Could that be collected so that when if flips, which it should do at some point, it can be flipped in one place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grand!
Hi, I am using the Neo4j Windows desktop version 3.1.4 and I tried to set the dbms.import.csv.legacy_quote_escaping to false. However, I can not find this variable in my C:\Users\txia\AppData\Roaming\Neo4j Community Edition\neo4j.conf. Here is what my neo4j.conf looks like(to attach it, I change it to .txt): Any idea? Thanks! |
@xiatian90s you should be able to just add it as a line to the end of your neo4j.conf file.
|
Hi, what is the default value for dbms.import.csv.legacy_quote_escaping if it is not specified in the config file? |
It's true by default, but may be flipped to false as default in a later version |
This is a bad solution. I think don't ask data to change for data is always big. Proposed Solution: |
changelog: Added a new config setting
dbms.import.csv.legacy_quote_escaping
to select whether to conform to the standard https://tools.ietf.org/html/rfc4180 for interpreting escaped quotation characters in CSV files loaded usingLOAD CSV
. Setting this tofalse
will use the standard, interpreting repeated quotes '""' as a single in-lined quote, whiletrue
will use the legacy convention originally supported in Neo4j 3.0 and 3.1, allowing a backslash to include quotes in-lined in fields.