Handle LocalDatabase restart breaking bolt connections #9114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneedham
changed the title
mneedham
force-pushed
the
3.2-meta-data-store-closed
branch
from
b58897b
to
2444efe
Compare
lutovich
approved these changes
Mar 30, 2017
| @@ -64,7 +65,7 @@ | |||
| TransactionStateMachineSPI( GraphDatabaseAPI db, | |||
| ThreadToStatementContextBridge txBridge, | |||
| QueryExecutionEngine queryExecutionEngine, | |||
| TransactionIdStore transactionIdStoreSupplier, | |||
| Supplier<TransactionIdStore> transactionIdStoreSupplier, | |||
There was a problem hiding this comment.
Could we maybe remove this param and take transactionIdStoreSupplier out of GraphDatabaseAPI db?
This is not very important but will reduce amount of constructor arguments.
There was a problem hiding this comment.
Have changed this to get TransactionIdStore from db.getDependencyResolver()...
| @@ -109,6 +110,6 @@ private boolean isReady( long oldestAcceptableTxId ) throws TransactionFailureEx | |||
| */ | |||
| public long newestEncounteredTxId() | |||
| { | |||
| return transactionIdStore.getLastClosedTransactionId(); | |||
| return transactionIdStoreSupplier.get().getLastClosedTransactionId(); | |||
There was a problem hiding this comment.
Maybe extract transactionIdStoreSupplier.get() in a method with a comment saying why is it required.
mneedham
force-pushed
the
3.2-meta-data-store-closed
branch
from
e0b3c4d
to
4602b55
Compare
|
@lutovich I've merged your branch into this one and then squashed everything. checkstyle locally seems happy so let's see if the build server agrees |
…tionIdStore not being refreshed * Introduce CANCELLED state so that polling process doesn't get restarted unless we explicitly want to restart it * Pass around a supplier of TransactionIdStore and resolve it in TransactionIdTracker * Bumped drivers to 1.2
mneedham
force-pushed
the
3.2-meta-data-store-closed
branch
from
4602b55
to
f8d8157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens because TransactionIdStore doesn't get refreshed after a store copy.