Attempt to stabilize BCCIT.shouldPickANewServerToWriteToOnLeaderSwitch #9162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks that the occasional failures of this test come from concurrent session creation and switching of leaders. This is not a problem in real deployments, but the fixed timeouts and specific requirements for leader election results along with the constant composition of the cluster violate some assumptions the test makes. This change ensures the leader switch that is needed completes before any further action is taken, and also makes sure that no additional elections are triggered during the session creations.
|
This looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks that the occasional failures of this test come from concurrent session
creation and switching of leaders. This is not a problem in real deployments,
but the fixed timeouts and specific requirements for leader election results
along with the constant composition of the cluster violate some assumptions
the test makes. This change ensures the leader switch that is needed completes
before any further action is taken, and also makes sure that no additional
elections are triggered during the session creations.