Fix for errors when a Rails model is named 'Property' #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for that! Awesome! I'll merge and try it. BTW, you can just reference the PR easily by using #107 and it will link up two PRs. |
|
|
||
| it "should save successfully when model is ::Property" do | ||
| class ::Property < Neo4j::Rails::Model |
There was a problem hiding this comment.
I think this should either be defined in advance (spec_helper?) or the constant should be undefined after the spec.
Otherwise this spec has global side-effects.
andreasronge
added a commit
that referenced
this pull request
Dec 15, 2011
Fix for errors when a Rails model is named 'Property' closes #108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andreas,
This is a fix for this bug: #107
Thanks,
Vivek