Backporting #1245 (Unpermitted parameters) to 7.2.x #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me, but I think that this would be Shall we release as 7.2? I've been trying to release patch versions whenever there's something to be released which leads us up to |
|
Since this fixes this bug: I considered it as a "bugfix", but instead it's a feature. So, for me it's ok to release a 7.2.x version ;) |
Current coverage is 97.24% (diff: 100%)@@ 7.1.x #1271 diff @@
==========================================
Files 168 170 +2
Lines 10426 10482 +56
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 10137 10193 +56
Misses 289 289
Partials 0 0
|
ProGM
changed the title
ProGM
added a commit
that referenced
this pull request
Aug 23, 2016
ProGM
added a commit
that referenced
this pull request
Aug 23, 2016
* 7.2.x: Bump version 7.2.0 CHANGELOG entry for #1271 Another try... Trying to fix gemfile. Refactor `using_action_controller` to print output. Fix typo. ActiveRel improvements to make permitted_attributes work on it. Make changes work with rails 4.x Support for Unpermitted Attributes API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #1245 to 7.x
I'm opening a PR since there where a few conflicts.
Pings:
@cheerfulstoic
@subvertallchris