A suggestion on NodeMixin interface

[junegunn]

Hi,
I think it would be more convenient if two NodeMixin class methods, property and index take arbitrary number of symbols followed by an optional hash.
Then we could write as follows,

  class Person
    include Neo4j::NodeMixin

    property :name, :address, :email, :type => String
    property :height, :weight, :type => Float
    index :name, :address, :type => :fulltext
    index :height, :weight
  end

This should feel natural to most Ruby developers.
I made changes to the both methods and spec files were extended accordingly.
The change is backward compatible.
So, what do you think? Please pull this patch if you think it's appropriate.
Thanks!

[andreasronge]

Looks good. Does it works for Neo4j::Rails::Model and Neo4j::Rails::Relationship as well ?
Check https://github.com/junegunn/neo4j/blob/master/lib/neo4j/property/class_methods.rb

[junegunn]

Yeah, it also works for them. I've tested, although I haven't extended the spec file. (my bad)

However, in fact, those two classes override the implementation of property method
by including Neo4j::Rails::Mapping::Property. And that version of property already processes arbitrary number of symbols and the options hash.
https://github.com/junegunn/neo4j/blob/master/lib/neo4j/rails/mapping/property.rb

So, this patch has no effect on property for those classes, but it still extends index.