Release 3.0.0.alpha.7 (the relationships edition) #353
Conversation
anulman
commented
Jun 6, 2014
anulman
commented
- Refactor HasN::DeclRel syntax to better match ActiveRecord
- Add build/where functions on DeclRel collections
- Add HasN::Rels class
- ActiveNode#where, ActiveNode#first helpers
- Introducing ActiveRel
- Refactor HasN::DeclRel syntax to better match ActiveRecord - Add build/where functions on DeclRel collections - Add HasN::Rels class - ActiveNode#where, ActiveNode#first helpers - Introducing ActiveRel
|
@andreasronge—Sorry this PR doesn't yet pass the spec suite. The gem is now working as I would expect it to in a sample app (n.b. with the new has_n syntax). Do you have any feedback on the changes and/or implementation? I'd rather not waste cycles on conformance for conformance's sake if at all possible :) |
| @@ -33,7 +33,7 @@ It comes included with the Apache Lucene document database. | |||
| s.add_dependency("activemodel", "~> 4") | |||
| s.add_dependency("railties", "~> 4") | |||
| s.add_dependency('active_attr', "~> 0.8") | |||
| s.add_dependency("neo4j-core", "= 3.0.0.alpha.14") | |||
| s.add_dependency("neo4j-core", "= 3.0.0.alpha.15") | |||
There was a problem hiding this comment.
This is the reason why travis does not build. Have you changed neo4j-core as well ?
There was a problem hiding this comment.
Yup. It's a dependency, as listed :)
There was a problem hiding this comment.
Aha, sorry did not see the pull request on neo4j-core.
|
This contains really nice stuff. However, I would like to fix the following before merging it
|
|
Thanks Andreas :) Sounds like a plan! I should have #s 1 and 2 implemented fairly quickly; however, I wasn't able to get Neo4j::Session.query working without a ton of code duplication due to relationship directionality and wonky match requirements. What's left before crel is implemented? I see you and @cheerfulstoic discussing API documentation in the other thread; is that it? |
|
I'm currently boning up on my cypher knowledge and re-thinking it somewhat from the ground up to move it from neo4j to neo4j-core. Currently it's more in the model world and I think it needs to be strictly in the query-generation world, so it's going to need to work differently for that. I'm putting together a draft of some wiki docs which we can look over. Should be ready in a day or two. |
|
@cheerfulstoic I may have built a clunky version of this in I intended to abstract the condition templates (currently instance methods in QueryElements) to a design like the one you expressed wonderfully in crel. If the CypherQuery code/design has any place in what you're working on, perhaps we could work together. |
|
Honestly I'm open to different ideas right now ;) I'd like to evaluate ASTs as a possible solution and I'm currently looking into arel's implementation. I don't want to do it wrong, but at the same time I don't want to sit around and theorize about it forever either ;) I've created a new thread for crel discussion in the neo4j-core gem repo over here, BTW: neo4jrb/neo4j-core#75 |
