Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require id property #476

Closed
wants to merge 27 commits into from
Closed

Require id property #476

wants to merge 27 commits into from

Commits on Sep 10, 2014

  1. A start on requiring primary keys on all nodes

    @cheerfulstoic
    cheerfulstoic committed Sep 10, 2014
    Configuration menu
    Copy the full SHA
    d183a6b View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2014

  1. Merge branch 'master' into require_id_property

    @cheerfulstoic
    cheerfulstoic committed Sep 11, 2014
    Configuration menu
    Copy the full SHA
    6a82d3c View commit details
    Browse the repository at this point in the history

  2. Progress toward getting specs to pass

    @cheerfulstoic
    cheerfulstoic committed Sep 11, 2014
    Configuration menu
    Copy the full SHA
    44848c0 View commit details
    Browse the repository at this point in the history

  3. More fixes

    @cheerfulstoic
    cheerfulstoic committed Sep 11, 2014
    Configuration menu
    Copy the full SHA
    704399a View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2014

  1. Fix for specs and a little bit of renaming for clarity

    @cheerfulstoic
    cheerfulstoic committed Sep 12, 2014
    Configuration menu
    Copy the full SHA
    6ad13b6 View commit details
    Browse the repository at this point in the history

  2. Change spec expectation (uuid field now added by default)

    @cheerfulstoic
    cheerfulstoic committed Sep 12, 2014
    Configuration menu
    Copy the full SHA
    42594f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2014

  1. Take advantage of Hash defaults

    @cheerfulstoic
    cheerfulstoic committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    99e5d97 View commit details
    Browse the repository at this point in the history

  2. Remove MongoDB object_id code and only use SecureRandom.uuid. Also fi… 

    …x some specs (added a call to id_property_info at the top of #create_model to make sure the UUID is there. There is probably a better way)
    @cheerfulstoic
    cheerfulstoic committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    d3cc6da View commit details
    Browse the repository at this point in the history

  3. Spec fixes for required UUID

    @cheerfulstoic
    cheerfulstoic committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    eb75d22 View commit details
    Browse the repository at this point in the history

  4. More cross-module calling

    @cheerfulstoic
    cheerfulstoic committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    9f4f58d View commit details
    Browse the repository at this point in the history

  5. More cross-module calling

    @cheerfulstoic
    cheerfulstoic committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    9228758 View commit details
    Browse the repository at this point in the history

  6. IDs aren't integers anymore

    @cheerfulstoic
    cheerfulstoic committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    eea5fc9 View commit details
    Browse the repository at this point in the history

  7. Little bit more before bed

    @cheerfulstoic
    cheerfulstoic committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    efd79b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2014

  1. Refactoring id_property code so that it only gets called once on end … 

    …of definition (using "defined" gem). Some more cleanup and spec fixes
    @cheerfulstoic
    cheerfulstoic committed Sep 15, 2014
    Configuration menu
    Copy the full SHA
    f12ae4d View commit details
    Browse the repository at this point in the history

  2. Whoops

    @cheerfulstoic
    cheerfulstoic committed Sep 15, 2014
    Configuration menu
    Copy the full SHA
    50abe88 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into require_id_property 

    Conflicts:
	spec/e2e/active_model_spec.rb
    @cheerfulstoic
    cheerfulstoic committed Sep 15, 2014
    Configuration menu
    Copy the full SHA
    699de72 View commit details
    Browse the repository at this point in the history

  4. Fixing specs

    @cheerfulstoic
    cheerfulstoic committed Sep 15, 2014
    Configuration menu
    Copy the full SHA
    3601006 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2014

  1. Fix the fixes with fixes and hopefully it fixes all of the things...

    @cheerfulstoic
    cheerfulstoic committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    bd73090 View commit details
    Browse the repository at this point in the history

  2. Defining more id_properties

    @cheerfulstoic
    cheerfulstoic committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    e945101 View commit details
    Browse the repository at this point in the history

  3. id_property for orm adapter test models

    @cheerfulstoic
    cheerfulstoic committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    aff9459 View commit details
    Browse the repository at this point in the history

  4. Almost there...

    @cheerfulstoic
    cheerfulstoic committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    6c95ccc View commit details
    Browse the repository at this point in the history

  5. Trying another push

    @cheerfulstoic
    cheerfulstoic committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    631e9f8 View commit details
    Browse the repository at this point in the history

  6. Make sure constraints for inherited models get set up

    @cheerfulstoic
    cheerfulstoic committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    1347f90 View commit details
    Browse the repository at this point in the history

  7. Make sure constraints are dropped before we test them

    @cheerfulstoic
    cheerfulstoic committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    1153bd5 View commit details
    Browse the repository at this point in the history

  8. Remove tracing line

    @cheerfulstoic
    cheerfulstoic committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    5ce2454 View commit details
    Browse the repository at this point in the history

  9. Try rescue nil because we don't care if it's not there

    @cheerfulstoic
    cheerfulstoic committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    e93729b View commit details
    Browse the repository at this point in the history

  10. Load the class outside the transaction so that we create the constrai… 

    …nt outside of the transaction where data is change
    @cheerfulstoic
    cheerfulstoic committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    e21b25a View commit details
    Browse the repository at this point in the history