fix uninitialized constant CarrierWave::Mount::Mounter #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,7 +48,7 @@ def clear_#{column} | |||
|
|
|||
| def _mounter(column) | |||
| @_mounters ||= {} | |||
| @_mounters[column] ||= CarrierWave::Mount::Mounter.new(self, column) | |||
| @_mounters[column] ||= CarrierWave::Mounter.new(self, column) | |||
There was a problem hiding this comment.
It looks like this was changed here:
carrierwaveuploader/carrierwave@1ac1268
The carrierwave gem seems to be encouraging people to use the master branch unless they're using Rails 3, but they README mentions something about a forthcoming 1.0 release. Their most recent publication to rubygems was 0.10.0 which was published Feb 26th, 2014 and that commit is from Oct 16, 2014.
Perhaps this could be something like:
mounter_class = defined?(CarrierWave::Mounter) ? CarrierWave::Mounter : CarrierWave::Mount::Mounter
@_mounters[column] ||= mounter_class.new(self, column)
|
Sorry I missed this! I came back to this project after seeing #12 and it seems like that actually may fix the issue. If not, please let me know |
|
I don't have permission to release a new version of the gem, so while I wait on that you can watch #12 for updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #10
change Carrierwave::Mount::Mounter to Carrierwave::Mounter